Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new healthcheck endpoint #348

Merged
merged 19 commits into from
Dec 5, 2023
Merged

feat: new healthcheck endpoint #348

merged 19 commits into from
Dec 5, 2023

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Oct 9, 2023

Depends on HathorNetwork/hathor-wallet-lib#579

Acceptance Criteria

  • Create a new /health endpoint to return information about the health of the wallets and the connected components (tx-mining-service, hathor-core).

Note: There is an unfinished TODO because we are still developing a new /health endpoint on hathor-core as well. It will be solved in a future PR to use the new endpoint there when it's ready.

Note: The tests are failing because they depend on the wallet-lib changes.

TODO

  • Bump the wallet-lib version after its next release

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl changed the base branch from master to dev October 9, 2023 18:00
@luislhl luislhl self-assigned this Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c643c77) 86.93% compared to head (ef44384) 86.93%.

Files Patch % Lines
src/helpers/healthcheck.helper.js 62.50% 6 Missing ⚠️
src/services/healthcheck.service.js 83.87% 5 Missing ⚠️
.../controllers/healthcheck/healthcheck.controller.js 94.44% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          38       42    +4     
  Lines        1561     1653   +92     
  Branches      322      341   +19     
=======================================
+ Hits         1357     1437   +80     
- Misses        182      194   +12     
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luislhl luislhl force-pushed the feat/health-check branch from a56fb31 to a9d6c3a Compare October 9, 2023 19:49
@luislhl luislhl marked this pull request as ready for review October 20, 2023 14:17
@luislhl luislhl requested a review from tuliomir October 20, 2023 14:19
src/controllers/healthcheck/healthcheck.controller.js Outdated Show resolved Hide resolved
src/helpers/healthcheck.helper.js Outdated Show resolved Hide resolved
__tests__/healthcheck.test.js Outdated Show resolved Hide resolved
__tests__/healthcheck.test.js Outdated Show resolved Hide resolved
src/helpers/healthcheck.helper.js Outdated Show resolved Hide resolved
@luislhl luislhl requested a review from tuliomir October 31, 2023 17:56
__tests__/healthcheck.test.js Outdated Show resolved Hide resolved
__tests__/healthcheck.test.js Outdated Show resolved Hide resolved
tuliomir
tuliomir previously approved these changes Nov 6, 2023
@luislhl luislhl requested a review from tuliomir November 13, 2023 19:52
src/api-docs.js Outdated Show resolved Hide resolved
pedroferreira1
pedroferreira1 previously approved these changes Nov 24, 2023
@luislhl luislhl changed the base branch from dev to master December 4, 2023 18:25
@luislhl luislhl dismissed stale reviews from pedroferreira1 and tuliomir December 4, 2023 18:25

The base branch was changed.

@luislhl luislhl merged commit 07c6e58 into master Dec 5, 2023
9 checks passed
@luislhl luislhl deleted the feat/health-check branch December 5, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants