-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new healthcheck endpoint #348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 38 42 +4
Lines 1561 1653 +92
Branches 322 341 +19
=======================================
+ Hits 1357 1437 +80
- Misses 182 194 +12
Partials 22 22 ☔ View full report in Codecov by Sentry. |
a56fb31
to
a9d6c3a
Compare
tuliomir
reviewed
Oct 20, 2023
tuliomir
reviewed
Oct 26, 2023
tuliomir
reviewed
Oct 31, 2023
tuliomir
previously approved these changes
Nov 6, 2023
tuliomir
reviewed
Nov 14, 2023
tuliomir
reviewed
Nov 23, 2023
pedroferreira1
previously approved these changes
Nov 24, 2023
The base branch was changed.
9e3320f
to
ef44384
Compare
pedroferreira1
approved these changes
Dec 5, 2023
tuliomir
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on HathorNetwork/hathor-wallet-lib#579
Acceptance Criteria
/health
endpoint to return information about the health of the wallets and the connected components (tx-mining-service, hathor-core).Note: There is an unfinished TODO because we are still developing a new
/health
endpoint on hathor-core as well. It will be solved in a future PR to use the new endpoint there when it's ready.Note: The tests are failing because they depend on the wallet-lib changes.
TODO
Security Checklist