fix: Alert unmount and overlay #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliomir
requested review from
pedroferreira1 and
andreabadesso
and removed request for
r4mmer
tuliomir
commented
Jan 16, 2025
Comment on lines
-978
to
-983
|
|
||
| &.fixed-position { | ||
| position: fixed !important; | ||
| right: 15%; | ||
| bottom: 50%; | ||
| } |
tuliomir
commented
Jan 16, 2025
| ref={alertDiv} | ||
| className={`new-hathor-alert alert alert-${type} alert-dismissible fade`} | ||
| role="alert" | ||
| style={{ display: 'flex', flexDirection: 'row' }} |
There was a problem hiding this comment.
I tried to avoid this style from the previous implementation, but the fade animations just wouldn't work without it. Decided to leave this cleanup to a future refactor.
tuliomir
force-pushed
the
fix/alert-unmount
branch
from
19d4e8f to
bc594ae
Compare
andreabadesso
approved these changes
Jan 17, 2025
| if (alertDiv?.current) { | ||
| alertDiv.current.classList.remove('show'); | ||
| } | ||
| }, duration); |
There was a problem hiding this comment.
You don't have this duration parameter here, if I'm not wrong. The diffs are a bit confusing but it seems like you should be receiving it as a parameter in the showAlertComponent also.
There was a problem hiding this comment.
This function is actually declare inside the show() function, so it shares the duration parameter.
The diff visualizarion is confusing, since some of the methods were obsolete and were removed, but you can see it more clearly on the file itself.
pedroferreira1
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some tests where many components were being clicked in short sequence, the
NewHathorAlertcomponent could break by being unable to manipulate the dom correctly: the expected element would already be unmounted when the timer finished.Also, the alert container for fixed positioning, used in the Navigation search, was overlaying the screen elements, preventing clicks on the application elements.
Acceptance Criteria
Security Checklist