-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): handle events during the load phase #534
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #534 +/- ##
==========================================
- Coverage 83.20% 83.20% -0.01%
==========================================
Files 211 211
Lines 18646 18644 -2
Branches 2590 2590
==========================================
- Hits 15514 15512 -2
+ Misses 2563 2562 -1
- Partials 569 570 +1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8acfd78
to
a4e6197
Compare
… to _initialize_components_new
a4e6197
to
9d8a616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's approved considering that we discussed to leave this provisional and make tweaks later.
Acceptance Criteria:
LOAD_FINISHED
event when the full node ends theLOAD
phase.LOAD_STARTED
event, because it wasn't used and is not necessary. If needed, existingMANAGER_ON_START
event serves the same purpose.NETWORK_NEW_TX_ACCEPTED
events for all txs during theLOAD
phase.--x-emit-load-events
flag, that enables emission of events published during theLOAD
phase.--x-enable-event-queue
flag.--x-full-verification
flag.