Replace old pause buffer input experience with a more accurate one #4918
+137
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
force-pushed
the
another-pass-on-pause-input-buffering
branch
from
2cebc5b to
60e483a
Compare
|
For some reason I totally forgot that Archez did another pass on the “Easy Pause Buffer” to fix some of the undesired behavior (#3054 (comment)) The new “include inputs held prior to buffer window” achieves the old behavior, prior to those fixes, so I’ll need to make some adjustments to include the improvement he made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the old mess I made with my previous attempt, with one that is much closer to hardware accurate. Any and all feedback is welcome.
Build Artifacts