fix crash when opening advanced resolution options #4916
Conversation
|
I'm on mobile so I can't check exactly, but I don't think this is correct. It's disabling and then reenabling on the next line now, so it's not actually impacting any widgets. |
|
Yep, testing side by side, this does not fix issue. At least it's an easy crash for me to reproduce This time I've commented out the offending logic from backtrace & now it's fixed. But seems like hacky workaround |
serprex
force-pushed
the
fix-resolution-crash
branch
from
2915dd4 to
baf9e4a
Compare
|
How interesting. I was just talking about that function with aMannus earlier today. I'm not exactly sure why it's crashing in the advanced resolution settings, though, considering that is used throughout the entire menubar. The way to fix the tooltips with that is to move that block you commented to the bottom of the function, after the PopItemFlag() call. But I get the feeling that won't fixe the advanced resolution issues. |
|
To clarify, the disabled tooltips still wouldn't show with the other tooltips where they are in SohMenuBar.cpp. |
fixes #4915
Build Artifacts