mOptionGroups: populate RSG_TRICKS with loop #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split out from #4866 since this is a) probably best split out, but also b) a bugfix which should make 9.0.0 |
serprex
commented
Jan 19, 2025
| auto& trick = mTrickOptions[i]; | ||
| if (!trick.GetName().empty()) { | ||
| mTrickNameToEnum[std::string(trick.GetName())] = static_cast<RandomizerTrick>(i); | ||
| auto trick = &mTrickOptions[i]; |
There was a problem hiding this comment.
changed declaration because the old way lead to invalid memory references when reference outlived loop into tricksOption
serprex
force-pushed
the
cleanup-tricks-option-group
branch
2 times, most recently
from
ab0a7e6 to
2d1d31d
Compare
There were some tricks missing, using loop makes one less place to update when adding tricks
serprex
force-pushed
the
cleanup-tricks-option-group
branch
from
2d1d31d to
c0ff97a
Compare
aMannus
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some tricks missing, using loop makes one less place to update when adding tricks
Build Artifacts