Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl3 #4859

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

sdl3 #4859

wants to merge 29 commits into from

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Jan 11, 2025

todo

  • figure out why mac isn't building
  • figure out a plan for SDL_net (it looks like the latest code on the main branch https://github.com/libsdl-org/SDL_net supports SDL3 but the release version is from 2022)
  • clean up naming with GameController -> Gamepad (got the big ones with bulk find/replace, but combing through to make sure names aren't confusing will be good)
  • TEST
  • remove all the inline comments linking to the SDL migration docs, decide if we want to keep them anywhere and if we do find a place for them to live
  • LAND IT

once that's done we can start playing with new SDL3 stuff!

Build Artifacts

@briaguya-ai briaguya-ai added the do not merge Not ready or not valid changes label Jan 11, 2025
@briaguya-ai briaguya-ai mentioned this pull request Jan 11, 2025
@Malkierian
Copy link
Contributor

As far as SDL_net is concerned, I guess we need to do a submodule of the repo instead of relying on package managers? I'd guess there isn't a version on package managers for it like there is for the SDL3 pre-releases.

@briaguya-ai
Copy link
Contributor Author

As far as SDL_net is concerned, I guess we need to do a submodule of the repo instead of relying on package managers? I'd guess there isn't a version on package managers for it like there is for the SDL3 pre-releases.

the issue isn't the lack of a package in package managers. we wouldn't need to submodule. we could use FetchContent like we do for ImGui (https://github.com/Kenix3/libultraship/blob/31df12cdb7b877f4f0790dcc216a2c9d3823d58b/cmake/dependencies/common.cmake#L16-L22), but with ImGui we at least are pulling a known released version by tag. until a version that supports SDL3 is tagged (https://github.com/libsdl-org/SDL_net/tags) we'd need to pull based on some random commit sha (which really doesn't seem like a good call for network stuff).

@Malkierian
Copy link
Contributor

As long as it works, I think it would be worth it to get the rest of SDL3 in, but that's just my opinion. There's just too much good with it.

@briaguya-ai
Copy link
Contributor Author

As long as it works, I think it would be worth it to get the rest of SDL3 in, but that's just my opinion. There's just too much good with it.

i don't know if it actually works or not, i haven't tried it, and it seems like a lot has changed

relevant info
from: libsdl-org/SDL#8062 (comment)

We're not currently planning an SDL3 port of SDL_net, although Maelstrom still uses it, so that may change. :)

from: libsdl-org/SDL_net#79

This is a complete redesign and rewrite of SDL_net for a 3.0 release. It has different goals and functionality than SDL2_net, of which I have retained no pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Not ready or not valid changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants