Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rando: vanilla dungeon rewards #4836

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jan 9, 2025

fixes #4671

exists already in ootr. becomes more useful with ootr's option to have compass tell boss reward, which a future update could add

Build Artifacts

@aMannus aMannus added this to the 9.0.0 milestone Jan 11, 2025
mOptions[RSK_SHUFFLE_DUNGEON_REWARDS] = Option::U8("Shuffle Dungeon Rewards", {"End of Dungeons", "Any Dungeon", "Overworld", "Anywhere"}, OptionCategory::Setting, CVAR_RANDOMIZER_SETTING("ShuffleDungeonReward"), mOptionDescriptions[RSK_SHUFFLE_DUNGEON_REWARDS], WidgetType::Combobox, RO_DUNGEON_REWARDS_END_OF_DUNGEON);
mOptions[RSK_SHUFFLE_DUNGEON_REWARDS] = Option::U8("Shuffle Dungeon Rewards", {"Vanilla", "End of Dungeons", "Any Dungeon", "Overworld", "Anywhere"}, OptionCategory::Setting, CVAR_RANDOMIZER_SETTING("ShuffleDungeonReward"), mOptionDescriptions[RSK_SHUFFLE_DUNGEON_REWARDS], WidgetType::Combobox, RO_DUNGEON_REWARDS_END_OF_DUNGEON);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of an open question for everyone. The default is still set to end of dungeon instead of vanilla. Do we want this to default to vanilla? So far we've had the intention to keep the randomizer settings default to "as vanilla as possible" to make entry as smooth as possible to newcomers, but I can see an argument for both sides in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think leaving them at End of Dungeon makes sense as one of the primary ways the main idea of rando is demonstrated. They go through the dungeons as normal, except for the items inside the dungeon, but this will show that it's not just normal chests that get shuffled without them feeling swindled or confused because they didn't get a dungeon reward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanilla dungeon rewards still has them at the end of dungeons, the difference is that they wouldn't be shuffled among themselves, so the 3 stones would always be in deku for kokiri emerald, DC for goron ruby, and jabu for zora sapphire etc:

Copy link
Contributor

@aMannus aMannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my open question earlier, looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add a "Vanilla" option for the "Dungeon Rewards" items
4 participants