Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 more Weather icons #57

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

BachToTheFuture
Copy link
Contributor

For issue #8:
Added new icons for 3 weather conditions:

  • hurricane
  • scattered snow showers
  • snow showers

@scottmc
Copy link
Member

scottmc commented Nov 5, 2018

Can you post png preview images of these three here in the comments for review?

@BachToTheFuture
Copy link
Contributor Author

BachToTheFuture commented Nov 6, 2018

@scottmc So far they look like this:
Hurricane:
weather_hurricane
Scattered snow showers:
weather_scattered_snow_showers
Snow showers:
weather_snow_showers

@humdingerb
Copy link
Member

humdingerb commented Nov 6, 2018

Looking good.

The cloud shadows of the 'Scattered snow showers' isn't quite right. They should be a bit smaller and nearer to the clouds. The snow flakes should be fewer than for 'Snow showers' and should be distributed to use the whole height of the icon (i.e. from cloud to bottom of the icon).

I wonder if using a gradient for the 'Hurricane' that is green with only a small portion white (or very light green) could be used to make the waves look like they got some froth at the tips...

@BachToTheFuture
Copy link
Contributor Author

@humdingerb Sure :)

@BachToTheFuture
Copy link
Contributor Author

BachToTheFuture commented Nov 7, 2018

@humdingerb: Changed some icons :)

  • changed shadow size and placement
  • added a little gradient to the water

Hurricane
weather_hurricane

Scattered Snow Showers
weather_scattered_snow_showers

This is a GCI task: https://codein.withgoogle.com/dashboard/task-instances/6224925888086016/

Copy link
Member

@humdingerb humdingerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scottmc scottmc merged commit c6f429d into HaikuArchives:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants