Store rules in flattened message instead of SQLite #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a few tests and it works fine, thanks! So SQLite is now only used to migrate older FilterRules over to flatB, right? I wonder how long we should support that migration and therefore the SQL dependency. |
|
Maybe a year or two after the next version bump on HaikuPorts? |
|
Sounds good. I create #129 as a reminder. |
|
Given that, I think we should release a new minor version as soon as convenient. Do you have any work that you'd like to be included that you can finish in the next few weeks? |
|
I'd like to get in a couple patches, yea, shouldn't be more than a week or two. |
|
Very good, no hurry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps over from using SQLite for rule storage to a flattened message, migrating over old SQL rules and backing up the old DB.