Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fast64 repo settings file (fast64.json) #825

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

Lilaa3
Copy link
Contributor

@Lilaa3 Lilaa3 commented Aug 19, 2024

Allows fast64 to know a repo's ideal settings as soon as decomp path is picked. Settings are the default except for:

  • Matstack Fix is on
  • Microcode is set to EX2
  • Force Extended RAM is off because hackersm64 already has it enabled by default
  • Refresh is set to HackerSM64 2.3.0 (Refresh 13)

Allows fast64 to know a repo's ideal settings as soon as decomp path is picked.
Settings are the default except for:
Matstack is on
Microcode is set to EX2
Force Extended RAM is off because hackersm64 already has it enabled by default
Refresh is set to Refresh 13
@Lilaa3 Lilaa3 requested a review from gheskett as a code owner August 19, 2024 14:45
@gheskett gheskett requested review from Reonu and arthurtilly August 19, 2024 14:49
@gheskett gheskett added the high priority Important, non-critical issue or feature / high priority label Aug 19, 2024
@Reonu
Copy link
Contributor

Reonu commented Aug 19, 2024

This is so fucking cool

@Lilaa3
Copy link
Contributor Author

Lilaa3 commented Aug 19, 2024

Do you guys wanna wait for Fast64 #426, I can put this as draft

@gheskett
Copy link
Collaborator

Yeah, that'd be the best option here since this is pointed at master.

@gheskett gheskett added the needs fast64 integration Dependent on changes to fast64 label Aug 20, 2024
@gheskett
Copy link
Collaborator

Wait, does GitHub even let you regress to draft? Either way I wouldn't bother closing this.

fast64.json Outdated Show resolved Hide resolved
@Lilaa3 Lilaa3 marked this pull request as draft August 21, 2024 11:22
@Lilaa3 Lilaa3 marked this pull request as ready for review August 24, 2024 12:05
@Lilaa3
Copy link
Contributor Author

Lilaa3 commented Aug 24, 2024

Since my pr is for the next release just using fast64 defaults should be good enough

fast64.json Outdated Show resolved Hide resolved
@Lilaa3 Lilaa3 requested a review from aglab2 August 25, 2024 18:27
Copy link
Collaborator

@aglab2 aglab2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@Lilaa3
Copy link
Contributor Author

Lilaa3 commented Sep 4, 2024

The pr is ready, fast64 will have it's 2.3.0 release this weekend, merging now should be fine but it can wait

@aglab2 aglab2 merged commit bf70500 into HackerN64:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Important, non-critical issue or feature / high priority needs fast64 integration Dependent on changes to fast64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants