Add libcart #752
Add libcart #752
Conversation
subrepo: subdir: "src/libcart" merged: "948358b8" upstream: origin: "https://github.com/devwizard64/libcart" branch: "main" commit: "948358b8" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
subrepo: subdir: "src/libcart" merged: "948358b8" upstream: origin: "https://github.com/devwizard64/libcart" branch: "main" commit: "948358b8" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
someone2639
added
enhancement
subrepo: subdir: "src/libcart" merged: "948358b8" upstream: origin: "https://github.com/devwizard64/libcart" branch: "main" commit: "948358b8" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
subrepo: subdir: "src/libcart" merged: "948358b8" upstream: origin: "https://github.com/devwizard64/libcart" branch: "main" commit: "948358b8" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
subrepo: subdir: "src/libcart" merged: "948358b8" upstream: origin: "https://github.com/devwizard64/libcart" branch: "main" commit: "948358b8" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
| ; DO NOT EDIT (unless you know what you are doing) | ||
| ; | ||
| ; This subdirectory is a git "subrepo", and this file is maintained by the | ||
| ; git-subrepo command. See https://github.com/ingydotnet/git-subrepo#readme | ||
| ; | ||
| [subrepo] | ||
| remote = https://github.com/devwizard64/libcart | ||
| branch = main | ||
| commit = 948358b8320f49e75b4a9e3b4e792ccaec866e0b | ||
| parent = 543d7add024fea312a8991b29a029a0ac0ed7bef | ||
| method = merge | ||
| cmdver = 0.4.6 |
There was a problem hiding this comment.
What's the advantage of subrepos over submodules exactly, and is it necessary here? Seems like subrepos aren't an actual part of git, so I'm hesitant to use this unless submodules/subtrees are no good here.
There was a problem hiding this comment.
submodules are an extra command for the end user which is Bad™ (think changing the required baserom name bad)
maintaining the subrepo is on the contributors with zero work for the end user
There was a problem hiding this comment.
It is? Cloning a repo with a submodule doesn't also clone the submodule?
There was a problem hiding this comment.
an end user would have to either run git clone --recursive or git submodule init --update after a clone to grab those submodules
There was a problem hiding this comment.
Welp...that sucks. What about with subtrees?
There was a problem hiding this comment.
those work but i found them harder to maintain (s2dex text engine used to be a subtree here but i just made it part of the main repo eventually)
There was a problem hiding this comment.
Well, whatever then. Could you update the libpl PR to use subrepos then since it sounds like submodules are bad
There was a problem hiding this comment.
libcart should really be a submodule, with an option to pull it down from within the makefile automatically. Idk what the issue is on libcart's front that requires code modification, but it sounds like whatever it is should be fixed over there afaict.
Also please get this out of src and move it to somewhere like lib because that just makes more sense.
No description provided.