Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move frame and z buffers to set positions for better performance #556

Closed
wants to merge 3 commits into from
Closed

Move frame and z buffers to set positions for better performance #556

wants to merge 3 commits into from

Conversation

aglab2
Copy link
Collaborator

@aglab2 aglab2 commented Dec 15, 2022

No description provided.

@aglab2 aglab2 requested a review from gheskett as a code owner December 15, 2022 14:45
gheskett
gheskett requested changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@gheskett gheskett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is crashing at the file select screen.

image

@Reonu Reonu added enhancement New feature or request needs verification Needs to be tested to ensure functionality needs console verification Needs to be tested on console to ensure functionality performance Issue or feature related to game performance labels Dec 17, 2022
@Reonu Reonu added this to the 2.1 milestone Dec 17, 2022
@Reonu
Copy link
Contributor

Reonu commented Dec 17, 2022

marking this as 2.1 unless anyone disagrees

@aglab2
Copy link
Collaborator Author

aglab2 commented Dec 17, 2022

I'd call it vNext for now, I need to look more into it clearly. Not sure I wll be able to figure out all the pitfalls soon.

@Reonu Reonu removed this from the 2.1 milestone Dec 17, 2022
@Reonu Reonu added the do not merge Do not merge (yet) label Dec 17, 2022
@gheskett gheskett added this to the 3.0 milestone Mar 6, 2023
@gheskett gheskett changed the base branch from develop/2.1.0 to develop/3.0.0 September 27, 2023 01:58
@gheskett gheskett requested a review from someone2639 December 16, 2023 06:13
@aglab2 aglab2 closed this Dec 16, 2023
@aglab2
Copy link
Collaborator Author

aglab2 commented Dec 16, 2023

Moved to #737 with better implementation

@aglab2 aglab2 deleted the 2.1.0-buf-move branch November 17, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gheskett gheskett gheskett requested changes

@someone2639 someone2639 Awaiting requested review from someone2639

Assignees

@aglab2 aglab2

Labels
do not merge Do not merge (yet) enhancement New feature or request needs console verification Needs to be tested on console to ensure functionality needs verification Needs to be tested to ensure functionality performance Issue or feature related to game performance
Projects
3.0 (Major Feature Update)
Status: Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aglab2 @Reonu @gheskett