Completing reports migration #41
Draft
+83
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-ostapenko
commented
Jan 7, 2025
| @@ -1,47 +1,74 @@ | |||
| const configs = new reports.HTTPArchiveReports() | |||
| const metrics = configs.listMetrics() | |||
|
|
|||
| // Adjust start and end dates to update reports retrospectively | |||
| const startDate = '2024-12-01' // constants.currentMonth; | |||
There was a problem hiding this comment.
TODO: remove hardcoded dates.
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (5)
definitions/output/reports/reports_dynamic.js:5
- Replace the hardcoded date with a constant or variable to avoid magic numbers.
const startDate = '2024-12-01' // constants.currentMonth;
definitions/output/reports/reports_dynamic.js:6
- Replace the hardcoded date with a constant or variable to avoid magic numbers.
const endDate = '2024-12-01' // constants.currentMonth;
includes/reports.js:25
- The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND
includes/reports.js:51
- The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND
infra/bigquery-export/reports.js:46
- Modifying this.storagePath directly can lead to unintended side effects. Consider resetting this.storagePath to its original value after the export is completed.
this.storagePath = this.storagePath + `${exportData.lense}/`
| @@ -6,6 +6,7 @@ export class ReportsExporter { | |||
| constructor () { | |||
| this.bigquery = new BigQueryExport() | |||
| this.storage = new StorageExport() | |||
| this.storagePath = 'reports/dev/' // TODO change to prod | |||
There was a problem hiding this comment.
The TODO comment should be addressed or removed if it's no longer relevant.
Suggested change
| this.storagePath = 'reports/dev/' // TODO change to prod | |
| this.storagePath = 'reports/' |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added lenses conditions to the sample reports.
Exported examples can be seen under
httparchive/reports/dev/path.