Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated CMS 2020 to Dutch #1820

Merged
merged 7 commits into from
Dec 21, 2020
Merged

Translated CMS 2020 to Dutch #1820

merged 7 commits into from
Dec 21, 2020

Conversation

strangernr7
Copy link
Contributor

Makes progress on #1750

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man you are on fire!!!

As you use "CMS'en" can't switch to single quotes so need to escape instead.

src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added the translation world wide web label Dec 21, 2020
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 21, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top quality translation again (well from a technical point of view - can't talk too much about the Dutch!)

Spotted a few things and then can merge this. BTW if you go into the Files tab you can batch accept any of these which is quicker than accepting one by one.

src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
src/content/nl/2020/cms.md Outdated Show resolved Hide resolved
@strangernr7
Copy link
Contributor Author

So basically for every english link we add an hreflang="en" except for links with "en" in URL?

@tunetheweb
Copy link
Member

So basically for every english link we add an hreflang="en" except for links with "en" in URL?

Ideally yes, except for internal links (as they should eventually be in Dutch), links that we have already converted to Dutch (e.g. I didn't add it to the Wordpress one as instead changed it to the Dutch version o that page), and links with /en/ or /en-US, https://en. in them.

@tunetheweb tunetheweb merged commit 9999d26 into HTTPArchive:main Dec 21, 2020
@strangernr7 strangernr7 deleted the CMS-2020-NL branch December 21, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants