Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated 2020/performance to Dutch #1791

Merged
merged 18 commits into from
Dec 17, 2020
Merged

translated 2020/performance to Dutch #1791

merged 18 commits into from
Dec 17, 2020

Conversation

strangernr7
Copy link
Contributor

Makes progress on #1750

@strangernr7 strangernr7 added the translation world wide web label Dec 17, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good but missed some spans.

src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
src/content/nl/2020/performance.md Outdated Show resolved Hide resolved
strangernr7 and others added 15 commits December 17, 2020 22:06
@strangernr7
Copy link
Contributor Author

Wow that's a lot them, sorry I'll definitely add those on the other files. Also what do the { } next to headers add?

@tunetheweb
Copy link
Member

tunetheweb commented Dec 17, 2020

Wow that's a lot them, sorry I'll definitely add those on the other files. Also what do the { } next to headers add?

Each header is also a link. For example: https://almanac.httparchive.org/en/2020/performance#core-web-vitals-largest-contentful-paint

The link anchor id is auto generated based on the header so when you add the spans you get an untidy id. The { } allows you to specify an id to override this rather than have the untidy id.

@tunetheweb tunetheweb merged commit 1e9d21d into HTTPArchive:main Dec 17, 2020
@strangernr7 strangernr7 deleted the performance-2020-NL branch December 17, 2020 21:20
@tunetheweb
Copy link
Member

Thank you! Super speedy and top quality effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants