Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 2019 Accessibility chapter to Dutch #1776

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Translate 2019 Accessibility chapter to Dutch #1776

merged 6 commits into from
Dec 16, 2020

Conversation

strangernr7
Copy link
Contributor

Makes progress on #1750

@strangernr7 strangernr7 added the translation world wide web label Dec 16, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I've noticed

src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Dec 16, 2020
@tunetheweb tunetheweb changed the title added 2019 accessibility chapter to dutch content folder Translate 2019 Accessibility chapter to Dutch Dec 16, 2020
@rviscomi
Copy link
Member

@noah-vdv thank you for your hard work translating content into Dutch! I love that we're making the Web Almanac more accessible to developers everywhere.

One thing I want to point out is that the 2019 content will be visited much less frequently than 2020 content. So I'd encourage you to prioritize 2020 chapters, especially the ones that are edited and getting the most traffic.

@strangernr7
Copy link
Contributor Author

@noah-vdv thank you for your hard work translating content into Dutch! I love that we're making the Web Almanac more accessible to developers everywhere.

One thing I want to point out is that the 2019 content will be visited much less frequently than 2020 content. So I'd encourage you to prioritize 2020 chapters, especially the ones that are edited and getting the most traffic.

Np and will do 👌

@tunetheweb
Copy link
Member

On that note I’ve just merged in the final version of the 2020 Accessibility chapter if this is a topic of particular interest to you. If not grab the most popular one ready to go (currently Performance).

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Other than the MDN links (there's a lot in this chapter unfortunately) if you get a chance to see if NL versions, and a few things I spotted below, think this is good to merge.

src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/nl/2019/accessibility.md Outdated Show resolved Hide resolved
@strangernr7
Copy link
Contributor Author

Alright, checked all the links and none (apart from the one you pointed out) had NL versions so if there's no other mistakes I think it's good to go.

@tunetheweb
Copy link
Member

Alright, checked all the links and none (apart from the one you pointed out) had NL versions so if there's no other mistakes I think it's good to go.

D'oh! Sorry for wasting your time.

Merging now...

@tunetheweb tunetheweb merged commit f5338f7 into HTTPArchive:main Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants