Fix: Adjust navbar-brand alignment for mobile. #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hegner @kartikaysaxena @eduardo-rodrigues @graeme-a-stewart All checks have passed successfully. Could you please review and approve the changes when you have a moment? Thank you! |
hegner
approved these changes
Jan 6, 2025
eduardo-rodrigues
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This sounds good. Thank you for the work 👍!
I can merge but let's see if @graeme-a-stewart has comments.
|
Yes, this looks like a great fix - thank you @Saloni-2005, much appreciated! |
|
Thank you, @graeme-a-stewart! @eduardo-rodrigues! and @hegner! I'm glad the fix works well. Looking forward to collaborating more in the future. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the styling of the navbar-brand to improve its vertical alignment on mobile screens. Specifically, a margin-top is added to shift the navbar-brand slightly downward for better visual alignment on smaller devices.
Changes
Added margin-top in the media query for screens smaller than 768px.
Adjusted padding and font size to optimize the appearance on mobile devices.
Motivation
Addresses issue #1390 , where the navbar-brand was not properly aligned on smaller screens.
Testing
Verified the alignment on different screen sizes to ensure the changes apply only to mobile devices without affecting the desktop view.
Before:
After:
@kartikaysaxena @hegner Could you please review this PR? Thankyou!