Insufficient bottom margin #1472 #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't just hurry to make a PR. You can always discuss with the community first, for the issue. Have some basic ethics, don't just overwhelm to contribute for gsoc. |
|
Sorry, I saw that there was no update on that issue for some time so I just contributed but I should have disscussed it before making a PR. Wont happen again |
klieret
requested changes
Dec 27, 2023
There was a problem hiding this comment.
To me that does not look very convincing.
I think @gunjjoshi meant only the bottom margin which is indeed somewhat small.
|
@klieret should I do another PR and fix it? |
|
You can either create a new PR or add another commit here (the commits are git squashed anyway) |
|
Thank you! |
klieret
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.