Throw exceptions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sin3point14
changed the title
wryonik
approved these changes
Aug 23, 2024
| @@ -1,36 +1,30 @@ | |||
| import java.io.File | |||
|
|
|||
| var SongExtensions = listOf("mp3", "wav", "flac", "opus", "m4a") | |||
| val SongExtensions = listOf("mp3", "wav", "flac", "opus", "m4a") | |||
There was a problem hiding this comment.
Let's add all the media formats supported by all the three media player libraries. Maybe we can add it in the next PR
There was a problem hiding this comment.
Yeah this is definitely not ideal, but we can figure that out later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the effort to add error handling everywhere, add a few checks.
The commits explain what they do