Merge pull request #244 from Art4/phpstan-level-1

Fix 8 errors and reach PHPStan level 1
H2-invent · Sep 10, 2024 · 20dd4b0 · 20dd4b0
2 parents 1ace325 + af75374
commit 20dd4b0
Show file tree

Hide file tree

Showing 14 changed files with 47 additions and 47 deletions.
diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -1,5 +1,5 @@
 parameters:
-    level: 0
+    level: 1
     paths:
         - bin/
         - config/

diff --git a/src/Controller/TeamMemberController.php b/src/Controller/TeamMemberController.php
@@ -23,6 +23,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Contracts\Translation\TranslatorInterface;
+use Throwable;
 
 class TeamMemberController extends BaseController
 {
@@ -227,9 +228,14 @@ public function mitgliederAdd(
         $errors = array();
         if ($form->isSubmitted() && $form->isValid()) {
             $newMembers = $form->getData();
-            $lines = explode("\n", $newMembers['member']);
 
-            if (!empty($lines)) {
+            try {
+                $lines = explode("\n", $newMembers['member']);
+            } catch (Throwable $th) {
+                $lines = [];
+            }
+
+            if (count($lines) > 0) {
                 foreach ($lines as $line) {
                     $newMember = trim($line);
                     $newUser = $inviteService->newUser($newMember);
@@ -325,9 +331,14 @@ public function teamMemberCreate(
 
         if ($form->isSubmitted() && $form->isValid()) {
             $newMembers = $form->getData();
-            $lines = explode("\n", $newMembers['member']);
 
-            if (!empty($lines)) {
+            try {
+                $lines = explode("\n", $newMembers['member']);
+            } catch (Throwable $th) {
+                $lines = [];
+            }
+
+            if (count($lines) > 0) {
                 foreach ($lines as $line) {
                     $newMember = trim($line);
                     $user = $inviteService->newUser($newMember);

diff --git a/src/Repository/AuditTomZieleRepository.php b/src/Repository/AuditTomZieleRepository.php
@@ -3,7 +3,6 @@
 namespace App\Repository;
 
 use App\Entity\AuditTomZiele;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -15,10 +14,10 @@
 class AuditTomZieleRepository extends PresetRepository
 {
     public function __construct(
-    protected readonly ManagerRegistry    $registry,
-    protected readonly TeamRepository     $teamRepository,
-)
-{
-    parent::__construct($this->registry, $this->teamRepository, AuditTomZiele::class);
+        protected readonly ManagerRegistry $registry,
+        TeamRepository                     $teamRepository,
+    )
+    {
+        parent::__construct($this->registry, $teamRepository, AuditTomZiele::class);
     }
 }
diff --git a/src/Repository/DatenweitergabeGrundlagenRepository.php b/src/Repository/DatenweitergabeGrundlagenRepository.php
@@ -3,7 +3,6 @@
 namespace App\Repository;
 
 use App\Entity\DatenweitergabeGrundlagen;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -16,9 +15,9 @@ class DatenweitergabeGrundlagenRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, DatenweitergabeGrundlagen::class);
+        parent::__construct($this->registry, $teamRepository, DatenweitergabeGrundlagen::class);
     }
 }
diff --git a/src/Repository/DatenweitergabeStandRepository.php b/src/Repository/DatenweitergabeStandRepository.php
@@ -3,8 +3,6 @@
 namespace App\Repository;
 
 use App\Entity\DatenweitergabeStand;
-use App\Entity\Team;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -17,9 +15,9 @@ class DatenweitergabeStandRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, DatenweitergabeStand::class);
+        parent::__construct($this->registry, $teamRepository, DatenweitergabeStand::class);
     }
 }
diff --git a/src/Repository/PresetRepository.php b/src/Repository/PresetRepository.php
@@ -24,9 +24,9 @@
 abstract class PresetRepository extends ServiceEntityRepository
 {
     public function __construct(
-        ManagerRegistry    $registry,
-        TeamRepository     $teamRepository,
-        string             $entityClass
+        ManagerRegistry                   $registry,
+        protected readonly TeamRepository $teamRepository,
+        string                            $entityClass
     )
     {
         parent::__construct($registry, $entityClass);

diff --git a/src/Repository/ProdukteRepository.php b/src/Repository/ProdukteRepository.php
@@ -3,8 +3,6 @@
 namespace App\Repository;
 
 use App\Entity\Produkte;
-use App\Entity\Team;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -17,9 +15,9 @@ class ProdukteRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, Produkte::class);
+        parent::__construct($this->registry, $teamRepository, Produkte::class);
     }
 }
diff --git a/src/Repository/VVTGrundlageRepository.php b/src/Repository/VVTGrundlageRepository.php
@@ -2,9 +2,7 @@
 
 namespace App\Repository;
 
-use App\Entity\Team;
 use App\Entity\VVTGrundlage;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -17,9 +15,9 @@ class VVTGrundlageRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository,VVTGrundlage::class);
+        parent::__construct($this->registry, $teamRepository,VVTGrundlage::class);
     }
 }
diff --git a/src/Repository/VVTPersonenRepository.php b/src/Repository/VVTPersonenRepository.php
@@ -4,7 +4,6 @@
 
 use App\Entity\Team;
 use App\Entity\VVTPersonen;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -17,10 +16,10 @@ class VVTPersonenRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, VVTPersonen::class);
+        parent::__construct($this->registry, $teamRepository, VVTPersonen::class);
     }
 
     public function findByTeam(Team $team)

diff --git a/src/Repository/VVTRisikenRepository.php b/src/Repository/VVTRisikenRepository.php
@@ -3,7 +3,6 @@
 namespace App\Repository;
 
 use App\Entity\VVTRisiken;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -16,9 +15,9 @@ class VVTRisikenRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, VVTRisiken::class);
+        parent::__construct($this->registry, $teamRepository, VVTRisiken::class);
     }
 }
diff --git a/src/Repository/VVTStatusRepository.php b/src/Repository/VVTStatusRepository.php
@@ -2,10 +2,7 @@
 
 namespace App\Repository;
 
-use App\Entity\Team;
 use App\Entity\VVTStatus;
-use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
-use Doctrine\ORM\QueryBuilder;
 use Doctrine\Persistence\ManagerRegistry;
 
 /**
@@ -18,9 +15,9 @@ class VVTStatusRepository extends PresetRepository
 {
     public function __construct(
         protected readonly ManagerRegistry    $registry,
-        protected readonly TeamRepository     $teamRepository,
+        TeamRepository                        $teamRepository,
     )
     {
-        parent::__construct($this->registry, $this->teamRepository, VVTStatus::class);
+        parent::__construct($this->registry, $teamRepository, VVTStatus::class);
     }
 }
diff --git a/src/Service/ApproveService.php b/src/Service/ApproveService.php
@@ -11,7 +11,6 @@
 use App\Entity\User;
 use Doctrine\ORM\EntityManagerInterface;
 use Exception;
-use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
 class ApproveService
@@ -20,7 +19,6 @@ class ApproveService
 
     public function __construct(
         EntityManagerInterface      $entityManager,
-        FormFactoryInterface        $formBuilder,
         private TranslatorInterface $translator,
     )
     {

diff --git a/src/Service/CronService.php b/src/Service/CronService.php
@@ -12,7 +12,6 @@
 use App\Entity\AkademieBuchungen;
 use Doctrine\ORM\EntityManagerInterface;
 use Psr\Log\LoggerInterface;
-use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 use Twig\Environment;
 
@@ -21,7 +20,6 @@ class CronService
 {
     public function __construct(
         private EntityManagerInterface $em,
-        FormFactoryInterface           $formBuilder,
         private LoggerInterface        $logger,
         private TranslatorInterface    $translator,
         private NotificationService    $notificationService,

diff --git a/src/Service/TeamService.php b/src/Service/TeamService.php
@@ -28,6 +28,7 @@
 use App\Repository\VVTRisikenRepository;
 use App\Repository\VVTStatusRepository;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
@@ -51,6 +52,9 @@ public function __construct(
 
     }
 
+    /**
+     * @throws Exception If $type is not a valid team type
+     */
     public function create($type, $id, Team $team): object
     {
         switch ($type) {
@@ -118,8 +122,7 @@ public function create($type, $id, Team $team): object
                 }
                 break;
             default:
-
-                break;
+                throw new Exception(sprintf('`%s` is an invalid team type.', strval($type)), 1);
 
         }
 
@@ -129,6 +132,9 @@ public function create($type, $id, Team $team): object
         return $data1;
     }
 
+    /**
+     * @throws Exception If $type is not a valid team type
+     */
     public function delete($type, $id): ?object
     {
         switch ($type) {
@@ -161,7 +167,7 @@ public function delete($type, $id): ?object
                 break;
 
             default:
-                break;
+                throw new Exception(sprintf('`%s` is an invalid team type.', strval($type)), 1);
 
         }