-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Green Storm Texture #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you added or updated the texture source file in the sources/textures directory?
As a more general comment - we haven't been accepting much new fan content into this repository as of late, mostly due to lack of review manpower. The sheer volume of activity these last few days has drawn my reviewer's eye, so I'm trying to look at basically everything. I'm wondering if, as a stratagem, we should simply back out all fan Ages and storylines and content associated with those fan Ages. In that way, the focus of this repository becomes a baseline for building a generic shard that can fairly easily have new Ages grafted onto it. Anyway, those musing don't IMO impact the fact that this PR is likely an improvement upon what is currently in master and will probably be accepted before any such mission change happens. |
Sure, I can do that - will update "sources" accordingly when I get a sec. |
Hey Hoikas - I'm not seeing an original version of psnlNewSky3VeryDark anywhere in our source textures, nor the variant of this that was previously created to cover the "stormy sky + veelay sky" case, so it doesn't seem like there's anything to replace. I can add what I have, but without the original texture present, it doesn't seem like there will be much point. |
I think adding your new version would be an improvement on not having anything at all 😉. When the relto page was originally accepted, we were probably trying to move too fast, not reviewing things appropriately just because they had been accepted to Cyan's shard. |
Fair enough :) we should try and see if we can track down Cyan's original storm cloud texture - could have sworn that was floating around somewhere - but for now I have added my green variant to the source textures under "Personal" using the same name as the reference in the prp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clear improvement. Thanks!
Improves the variant of the stormy cloud texture Relto uses when the while the "green sky" (Veelay) page is active.
This is the counterpart to content/145 in the OpenUru Foundry, included in the Q3 2024 update to MOULa. However, there are some notable differences to be aware of, due to OU/MOULa and H'uru/moul-assets being slightly out of sync: