Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Green Storm Texture #261

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

patmauro
Copy link
Contributor

@patmauro patmauro commented Nov 2, 2024

Improves the variant of the stormy cloud texture Relto uses when the while the "green sky" (Veelay) page is active.

This is the counterpart to content/145 in the OpenUru Foundry, included in the Q3 2024 update to MOULa. However, there are some notable differences to be aware of, due to OU/MOULa and H'uru/moul-assets being slightly out of sync:

  1. OU contains an optimization made by @Hazado which splits out all the fan content into separate PRPs so they are more modular, but this change is not present in H'uru/moul-asets yet. As such, the equivalent change here is applied directly to Personal_District_Textures rather than Personal_District_psnlFanYeeshaPages01, as the asset in question has not been split off from the _Textures file and repackaged into _psnlFanYeeshaPages01 in the version currently on H'uru/moul-assets.
  2. There is a known issue where the sun and moon objects do not display properly through the cloud layer, and this is especially noticeable here. @Hazado added a fix which is currently on OU/MOULa adjusting the layer the objects are drawn in which fixes this issue, but H'uru/moul-assets does not have this fix yet. As such the sun and moon will not be visible while this "stormy veelay" variant is active.

@Hoikas Hoikas added visual An issue or fix that is primarily visual subjective An issue or fix that is artistic or creative in nature labels Nov 3, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you added or updated the texture source file in the sources/textures directory?

@Hoikas Hoikas added the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

As a more general comment - we haven't been accepting much new fan content into this repository as of late, mostly due to lack of review manpower. The sheer volume of activity these last few days has drawn my reviewer's eye, so I'm trying to look at basically everything. I'm wondering if, as a stratagem, we should simply back out all fan Ages and storylines and content associated with those fan Ages. In that way, the focus of this repository becomes a baseline for building a generic shard that can fairly easily have new Ages grafted onto it. Anyway, those musing don't IMO impact the fact that this PR is likely an improvement upon what is currently in master and will probably be accepted before any such mission change happens.

@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Have you added or updated the texture source file in the sources/textures directory?

Sure, I can do that - will update "sources" accordingly when I get a sec.

@dgelessus
Copy link
Contributor

Regarding @Hoikas' comment - for reference, the last discussion about what amount/kind of fan content should be kept in this repo: #234

@patmauro
Copy link
Contributor Author

patmauro commented Nov 3, 2024

Have you added or updated the texture source file in the sources/textures directory?

Hey Hoikas - I'm not seeing an original version of psnlNewSky3VeryDark anywhere in our source textures, nor the variant of this that was previously created to cover the "stormy sky + veelay sky" case, so it doesn't seem like there's anything to replace. I can add what I have, but without the original texture present, it doesn't seem like there will be much point.

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

I think adding your new version would be an improvement on not having anything at all 😉. When the relto page was originally accepted, we were probably trying to move too fast, not reviewing things appropriately just because they had been accepted to Cyan's shard.

@patmauro
Copy link
Contributor Author

patmauro commented Nov 4, 2024

I think adding your new version would be an improvement on not having anything at all 😉. When the relto page was originally accepted, we were probably trying to move too fast, not reviewing things appropriately just because they had been accepted to Cyan's shard.

Fair enough :) we should try and see if we can track down Cyan's original storm cloud texture - could have sworn that was floating around somewhere - but for now I have added my green variant to the source textures under "Personal" using the same name as the reference in the prp.

@Hoikas Hoikas removed the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 4, 2024
@patmauro patmauro mentioned this pull request Nov 5, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear improvement. Thanks!

@Hoikas Hoikas merged commit 30d925d into H-uru:master Nov 10, 2024
1 check passed
@patmauro patmauro deleted the improveReltoVeelayStorm branch November 10, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subjective An issue or fix that is artistic or creative in nature visual An issue or fix that is primarily visual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants