-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lake Lighting Project #938
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The challenge with this PR is that the updated SDL means that we cannot accept this until the new SDL is deployed to all shards of interest (MOULa, Minkatas). That's not a request to change anything, just an observation.
BTW in Python code, we prefer to insert a single whitespace after commas. See PEP8.
Co-authored-by: Adam Johnson <[email protected]>
Whitespace cleaned up in SDL files
Updated with changes requested |
Chose to use the Teledahn setting due to Teledahns fni using the same fog colors and def colors
cityDalek.py looks like a special case of xAgeSDLIntShowHide.py can we use that instead? It would be nice to not have to maintain more redundant code 😉 |
Make it more moula friendly name :)
I tested using xAgeSDLIntShowHide.py and it did not work well due to the objects in question having a vis sdl on them as well. |
Found that the lake light meter would show the numbers even if it was supposed to be hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, pending the assets end of the equation.
Used to change the fog color over Dni time, giving it an gradual glow and ebb over time
New python script added for controlling fog color using dni day. Should cause the fog to glow and darken along with the lake light |
Co-authored-by: Adam Johnson <[email protected]>
SDL
Var Byte nb01LakeLightState added to ages
Age
Updated to use Neighborhood Time Fix
H-uru/moul-assets#52