Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lake Lighting Project #938

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented Jun 19, 2021

SDL
Var Byte nb01LakeLightState added to ages

Age
Updated to use Neighborhood Time Fix

H-uru/moul-assets#52

Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The challenge with this PR is that the updated SDL means that we cannot accept this until the new SDL is deployed to all shards of interest (MOULa, Minkatas). That's not a request to change anything, just an observation.

BTW in Python code, we prefer to insert a single whitespace after commas. See PEP8.

Scripts/Python/xLakeLightCycle.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeLightCycle.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeLightCycle.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeLightCycle.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeLightCycle.py Outdated Show resolved Hide resolved
Scripts/SDL/GreatZero.sdl Outdated Show resolved Hide resolved
Scripts/SDL/Kveer.sdl Outdated Show resolved Hide resolved
Scripts/SDL/city.sdl Outdated Show resolved Hide resolved
Scripts/SDL/city.sdl Outdated Show resolved Hide resolved
Scripts/SDL/city.sdl Outdated Show resolved Hide resolved
@Hazado
Copy link
Contributor Author

Hazado commented Jun 20, 2021

Updated with changes requested

Hazado added 2 commits June 22, 2021 10:38
Chose to use the Teledahn setting due to Teledahns fni using the same fog colors and def colors
@Hoikas
Copy link
Member

Hoikas commented Sep 8, 2021

cityDalek.py looks like a special case of xAgeSDLIntShowHide.py can we use that instead? It would be nice to not have to maintain more redundant code 😉

Make it more moula friendly name :)
@Hazado
Copy link
Contributor Author

Hazado commented Sep 8, 2021

I tested using xAgeSDLIntShowHide.py and it did not work well due to the objects in question having a vis sdl on them as well.

Found that the lake light meter would show the numbers even if it was supposed to be hidden
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, pending the assets end of the equation.

Used to change the fog color over Dni time, giving it an gradual glow and ebb over time
@Hazado
Copy link
Contributor Author

Hazado commented Nov 1, 2021

New python script added for controlling fog color using dni day.
Highest point is 0.5, lowest is 0 or 1

Should cause the fog to glow and darken along with the lake light

Scripts/Python/islmLakeLightMeter.py Show resolved Hide resolved
Scripts/Python/islmLakeLightMeter.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeFogControl.py Outdated Show resolved Hide resolved
Scripts/Python/xLakeFogControl.py Outdated Show resolved Hide resolved
Co-authored-by: Adam Johnson <[email protected]>
@Hazado Hazado marked this pull request as draft December 14, 2021 16:12
@Hoikas Hoikas added Enhancement Non-critical feature addition Python Issues stemming from the Python API files labels Feb 23, 2022
@dpogue dpogue added the Content Pull Requests related to game content label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Pull Requests related to game content Enhancement Non-critical feature addition Python Issues stemming from the Python API files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants