Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved naming 1 - ForceChat, RenderEmote #596

Merged
merged 9 commits into from
Jan 23, 2025

Move exactMove into Character

73d6575
Select commit
Loading
Failed to load commit list.
Merged

Improved naming 1 - ForceChat, RenderEmote #596

Move exactMove into Character
73d6575
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 0s

34.78% (-0.01%) compared to cad1007

View this Pull Request on Codecov

34.78% (-0.01%) compared to cad1007

Details

Codecov Report

Attention: Patch coverage is 40.83333% with 71 lines in your changes missing coverage. Please review.

Project coverage is 34.78%. Comparing base (cad1007) to head (73d6575).

Files with missing lines Patch % Lines
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 18 Missing ⚠️
...ld/gregs/voidps/engine/entity/character/Visuals.kt 0.00% 13 Missing ⚠️
.../gregs/voidps/engine/suspend/SuspendableContext.kt 0.00% 8 Missing ⚠️
...ps/engine/entity/character/player/PlayerVisuals.kt 0.00% 4 Missing ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts 0.00% 3 Missing ⚠️
...oidps/world/interact/entity/npc/move/Ducklings.kts 33.33% 1 Missing and 1 partial ⚠️
...egs/voidps/world/map/lumbridge/LumbridgeChurch.kts 0.00% 2 Missing ⚠️
...n/world/gregs/voidps/world/map/varrock/Delrith.kts 0.00% 2 Missing ⚠️
...ld/gregs/voidps/network/login/protocol/Encoders.kt 0.00% 2 Missing ⚠️
...network/login/protocol/visual/encode/SayEncoder.kt 0.00% 2 Missing ⚠️
... and 15 more
Additional details and impacted files
Files with missing lines Coverage Δ
...ctivity/skill/agility/course/BarbarianAdvanced.kts 100.00% <100.00%> (ø)
...ld/activity/skill/agility/course/GnomeAdvanced.kts 92.85% <100.00%> (ø)
...activity/skill/agility/course/WildernessCourse.kts 85.62% <100.00%> (ø)
...voidps/world/activity/skill/prayer/BoneBurying.kts 38.09% <100.00%> (ø)
...s/world/activity/skill/runecrafting/EssenceMine.kt 85.00% <100.00%> (ø)
...ps/world/activity/skill/thieving/Pickpocketing.kts 75.00% <100.00%> (ø)
...ld/gregs/voidps/world/interact/entity/npc/Cows.kts 53.33% <100.00%> (ø)
...nteract/entity/player/combat/consume/drink/Tea.kts 74.50% <100.00%> (ø)
.../gregs/voidps/world/map/karamja/BartenderZambo.kts 52.17% <100.00%> (ø)
...gregs/voidps/world/map/lumbridge/LumbridgeFlag.kts 100.00% <100.00%> (ø)
... and 29 more

... and 5 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
- Coverage     34.78%   34.78%   -0.01%     
+ Complexity     4857     4856       -1     
============================================
  Files          1339     1339              
  Lines         47132    47123       -9     
  Branches       9518     9516       -2     
============================================
- Hits          16397    16393       -4     
+ Misses        27355    27345      -10     
- Partials       3380     3385       +5
Components Coverage Δ
Content 28.61% <65.71%> (-0.01%) ⬇️
Engine 43.29% <0.00%> (+0.04%) ⬆️
Network 71.85% <42.85%> (-0.08%) ⬇️
View more details on Codecov