Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More settings and command fixes #579

Merged
merged 7 commits into from
Jan 12, 2025
Merged

More settings and command fixes #579

merged 7 commits into from
Jan 12, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jan 12, 2025

  • Add aggression toggle
  • Disable world messages by default
  • Add player auto saving
  • Improve README setup guide
  • Update obj spawn command

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 31.42857% with 24 lines in your changes missing coverage. Please review.

Project coverage is 34.56%. Comparing base (0c6ea81) to head (0134285).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/voidps/world/interact/entity/player/AutoSave.kts 28.57% 13 Missing and 2 partials ⚠️
...gregs/voidps/world/command/debug/DebugCommands.kts 0.00% 6 Missing ⚠️
...ps/world/interact/entity/npc/combat/Aggression.kts 0.00% 0 Missing and 2 partials ⚠️
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n/world/gregs/voidps/engine/data/AccountManager.kt 75.94% <100.00%> (ø)
...otlin/world/gregs/voidps/engine/data/PlayerSave.kt 56.33% <100.00%> (ø)
.../voidps/engine/data/yaml/PlayerYamlReaderConfig.kt 96.77% <ø> (-0.11%) ⬇️
...ne/entity/character/player/skill/exp/Experience.kt 86.48% <100.00%> (-0.36%) ⬇️
game/src/main/kotlin/world/gregs/voidps/Main.kt 0.00% <ø> (ø)
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 71.42% <0.00%> (ø)
...ps/world/interact/entity/npc/combat/Aggression.kts 21.42% <0.00%> (ø)
...gregs/voidps/world/command/debug/DebugCommands.kts 3.38% <0.00%> (+0.11%) ⬆️
...s/voidps/world/interact/entity/player/AutoSave.kts 28.57% <28.57%> (ø)

... and 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #579      +/-   ##
============================================
- Coverage     34.57%   34.56%   -0.01%     
+ Complexity     4856     4854       -2     
============================================
  Files          1343     1344       +1     
  Lines         47161    47172      +11     
  Branches       9550     9555       +5     
============================================
+ Hits          16306    16307       +1     
- Misses        27454    27462       +8     
- Partials       3401     3403       +2     
Components Coverage Δ
Content 28.24% <20.68%> (-0.02%) ⬇️
Engine 43.16% <83.33%> (-0.02%) ⬇️
Network 71.92% <ø> (+0.07%) ⬆️

@GregHib GregHib merged commit a41dd53 into main Jan 12, 2025
5 checks passed
@GregHib GregHib deleted the command-fixes branch January 12, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant