Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve commands #578

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Improve commands #578

merged 6 commits into from
Jan 10, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jan 10, 2025

  • Handle errors in events Error handling in game loop #539
  • Add help command to list all commands
  • Add descriptions and usage syntax to useful commands
  • Combine all unlock related commands into one
  • Improve obj spawn command
  • Improve find command
  • Add few exact locations to tele command
  • Add song playing by name
  • Combine all under related commands into one

Copy link

github-actions bot commented Jan 10, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 9.45455% with 249 lines in your changes missing coverage. Please review.

Project coverage is 34.57%. Comparing base (30c01ae) to head (29fec79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gregs/voidps/world/command/admin/AdminCommands.kts 3.96% 97 Missing ⚠️
...gregs/voidps/world/command/debug/DebugCommands.kts 6.12% 46 Missing ⚠️
...rld/gregs/voidps/engine/client/ui/event/Command.kt 0.00% 35 Missing ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts 0.00% 22 Missing ⚠️
...ld/gregs/voidps/world/activity/quest/BookPages.kts 0.00% 13 Missing ⚠️
...s/voidps/world/command/debug/InterfaceCommands.kts 14.28% 12 Missing ⚠️
...c/main/kotlin/world/gregs/voidps/bot/BotSpawns.kts 0.00% 5 Missing ⚠️
...n/kotlin/world/gregs/voidps/engine/event/Events.kt 60.00% 3 Missing and 1 partial ⚠️
...dps/world/interact/entity/player/toxin/Disease.kts 0.00% 4 Missing ⚠️
...idps/world/interact/entity/player/toxin/Poison.kts 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
Files with missing lines Coverage Δ
...oidps/engine/client/instruction/InstructionTask.kt 0.00% <ø> (ø)
...s/voidps/world/activity/achievement/TaskSystem.kts 42.75% <ø> (+1.42%) ⬆️
...n/world/gregs/voidps/world/activity/quest/Quest.kt 23.07% <100.00%> (+18.31%) ⬆️
...gregs/voidps/world/community/friend/NameChange.kts 6.89% <100.00%> (ø)
...orld/interact/entity/player/display/tab/Emotes.kts 6.52% <ø> (+0.35%) ⬆️
...oidps/world/interact/entity/player/music/Music.kts 77.77% <ø> (+7.77%) ⬆️
...orld/gregs/voidps/world/activity/bank/BankOpen.kts 37.50% <0.00%> (ø)
...s/world/activity/dnd/shootingstar/ShootingStar.kts 6.25% <0.00%> (ø)
...regs/voidps/world/command/admin/ObjectCommands.kts 16.66% <0.00%> (ø)
...tlin/world/gregs/voidps/world/community/Rights.kts 4.76% <0.00%> (ø)
... and 12 more

... and 3 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #578      +/-   ##
============================================
- Coverage     34.62%   34.57%   -0.05%     
- Complexity     4850     4852       +2     
============================================
  Files          1344     1343       -1     
  Lines         47073    47161      +88     
  Branches       9527     9550      +23     
============================================
+ Hits          16297    16304       +7     
- Misses        27373    27457      +84     
+ Partials       3403     3400       -3     
Components Coverage Δ
Content 28.24% <8.69%> (-0.06%) ⬇️
Engine 43.17% <13.33%> (-0.05%) ⬇️
Network 71.85% <ø> (ø)

@GregHib GregHib merged commit 0c6ea81 into main Jan 10, 2025
5 checks passed
@GregHib GregHib deleted the command-improvements branch January 10, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant