Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix al-kharid gate integration tests #571

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Fix al-kharid gate integration tests #571

merged 2 commits into from
Dec 28, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Dec 28, 2024

Fix for #570
Reminder for self: integration tests don't run on PR's from forks as they don't have the AWS secret for the cache download.

Note: integration tests don't run on PR's from forks as they don't have the AWS secret for the cache download.
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.99%. Comparing base (77b9f90) to head (8a25bc7).
Report is 2 commits behind head on main.

Additional details and impacted files

see 4 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #571      +/-   ##
============================================
+ Coverage     33.96%   33.99%   +0.02%     
- Complexity     4801     4803       +2     
============================================
  Files          1319     1319              
  Lines         45873    45873              
  Branches       9337     9337              
============================================
+ Hits          15582    15595      +13     
+ Misses        26986    26977       -9     
+ Partials       3305     3301       -4     
Components Coverage Δ
Content 27.01% <100.00%> (+0.05%) ⬆️
Engine 43.21% <ø> (ø)
Network 70.69% <ø> (ø)

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@GregHib GregHib merged commit 5ae1b8f into main Dec 28, 2024
5 checks passed
@GregHib GregHib deleted the gate-integration-tests branch December 28, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant