Skip to content

Commit

Permalink
Add fletching skill, bows, arrows, darts, crossbows, bolts (#513)
Browse files Browse the repository at this point in the history
* * Add data classes for `bolt fletching` and `dart fletching`
* Add all fletchable bolts
* Add all fletchable darts
* Add level requirements and xp rewards to items in `items.yml`
* Add `FletchBolts.kt` for handling bolt fletching
* Add `FletchDarts.kt` for handling dart fletching
* Add `Arrows.kts` to handle adding `feathers` to `arrowshafts`
* Remove duplicate element in `items.yml`
* Add animation id's for making bolts, darts, fletching log

* * Add `Arrows.kts` to handle adding `feathers` to `arrowshafts`

* * Remove unfinished code from `Arrows.kts`

* * Remove redundant comments in code.

* * Fix incorrect int in `Arrows.kts`

* * Move player animation, xp reward and game message outside `inventory.transaction`

* * Remove fletching animation that were bugged from `animations.yml`
* Add animation `generic_fletch` as a replacement and best fit for dart making, bolt making, and feather to arrow shafts.

* * Remove animations for dart, bolts, headless arrows this bring this inline with RuneScape in this era

* * Add bolt tipping, mithril grapple bolt unfinished and finished and kebbit bolt, long kebbit bolt make

* * Add the ability to tip all arrows
* Add the ability to top all "brutal arrows"

* * Add fletching animation to `animation.yml`
* Add Fletching.kt to handle fletching logs to unfinished items
* Add FletchUnfinished.kts to handle making unfinished bows, arrow shafts and stocks
* Add fletching data to items in items.yml
* Add the ability to fletch ogre comp bows to item-on-item.yml
* Add the ability to string bows from `normal bow` to `magic bow`
* Add the ability to create unstrung crossbow
* Add the ability to string unstrung crossbows

* * Change comments in Fletching.kt

* * Add missing animations to animations.yml

* * Remove function `getFletchItems` and moved the data to `items.yml`.
* Add game message when a player doesn't have the materials to fletch an item.

* * Moved fletchable data from cursed magic logs to magic logs

* Fix item-on-items maximum

* Remove manual item-on-item order switching

* Formatting and add shaft to message list

* * Changed `timer` to `queue` this is because a timer is never started but a queue is.
* Remove various checks to filter what item is needed during an `iteonitem` interaction

* Fix invalid items and add item id check

* * Change the name of `Arrows.kts` to `HeadlessArrows.kts` to better reflect what the script handles

* Add plurals to item-on-item messages and add minimum to make maximum

---------

Co-authored-by: GregHib <[email protected]>
  • Loading branch information
Syntax2022 and GregHib authored Apr 25, 2024
1 parent ec11ec2 commit d6fb3bf
Show file tree
Hide file tree
Showing 14 changed files with 1,320 additions and 11 deletions.
22 changes: 21 additions & 1 deletion data/definitions/animations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1647,4 +1647,24 @@ gunthor_announcement: 14734
kjell_cheer: 1531
haakon_cheer: 14739
mixing_potion: 363
pestle_and_mortar: 5249
pestle_and_mortar: 5249
fletching_log: 1248
fletching_string_normal_shortbow: 6678
fletching_string_normal_longbow: 6684
fletching_string_oak_shortbow: 6679
fletching_string_oak_longbow: 6685
fletching_string_willow_shortbow: 6680
fletching_string_willow_longbow: 6686
fletching_string_maple_shortbow: 6681
fletching_string_maple_longbow: 6687
fletching_string_yew_shortbow: 6682
fletching_string_yew_longbow: 6688
fletching_string_magic_shortbow: 6683
fletching_string_magic_longbow: 6689
fletching_string_bronze_crossbow: 6671
fletching_string_blurite_crossbow: 6672
fletching_string_iron_crossbow: 6673
fletching_string_steel_crossbow: 6674
fletching_string_mithril_crossbow: 6675
fletching_string_adamant_crossbow: 6676
fletching_string_rune_crossbow: 6677
Loading

0 comments on commit d6fb3bf

Please sign in to comment.