Tidy up ShadowApplicationPlugin
#1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f6ca4d.
Goooler
force-pushed
the
g/20250126/clean-up-app-plugin
branch
from
9aa497a to
ca094d0
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt: Language not supported
Goooler
changed the title
Goooler
commented
Jan 29, 2025
Comment on lines
68
to
69
| // `startShadowScripts` is not cacheable, so it's always executed. | ||
| assertExecutionSuccess() |
There was a problem hiding this comment.
expected:<[SUCCESS]> but was:<[UP_TO_DATE]> (org.gradle.testkit.runner.internal.FeatureCheckBuildResult@efde75f)
Expected :SUCCESS
Actual :UP_TO_DATE
No idea about this.
Goooler
commented
Jan 29, 2025
| @@ -77,7 +77,6 @@ public abstract class ShadowApplicationPlugin : Plugin<Project> { | |||
| project.resources.text.fromString(windowsStartScript) | |||
|
|
|||
| task.classpath = project.files(shadowJar) | |||
| task.inputs.files(project.files(shadowJar)) | |||
There was a problem hiding this comment.
Address this to #1216.
Goooler
changed the title
ShadowApplicationPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.