2.0 hybridity #159
Merged
2.0 hybridity #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now depends on GoogleWebComponents/google-apis#80 to be merged and a 2.0.0 release. Tested against the preview branch from the PR. |
|
Who controls the google APIs project for the demo @addyosmani @ebidel @Zoramite? |
e111077
approved these changes
Sep 5, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged into a 2.0-preview branch which doesn't exist yet. If you create the branch I can change the PR accordingly.
This also depends on a 2.0-preview branch in google-apis, which doesn't exist yet. For testing I used the version from this PR: GoogleWebComponents/google-apis#79
The main issue for making this work for 2.0 seems to be that the "ready" event doesn't fire unless an element is actually added to the DOM (and not only created), which is why the api-loader needs to be added to the DOM when using the element in 2.0.
This solves #158.