Add initialized property to detect when auth library has initialized #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signedIn property. This is to be able to avoid flickering gui until signedIn property has a correct value.
|
This looks good to me. |
|
@ebidel This change looks good to me for allowing the user to know if the library has initialized before reading the logged in status without backwards incompatibility. I don't have write access to the repo anymore so if you can check this out it would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to easily display something like a dialog when user is not signed in, we need to know when the signedIn property is set based on first reponse from auth library rather than the default false value.
Adding a property such as this change does makes this possible.
I believe this solves issue #137 and #121 as well as my own need for such a feature.