Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compile on macos action #9640

Conversation

alphanota
Copy link
Contributor

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, authored by alphanota, adds a GitHub Actions workflow to compile Skaffold on macOS. The intent is to improve the cross-compilation process and ensure Skaffold builds correctly on this platform.

Here's a breakdown of the changes:

  • A new .github/workflows/compile-mac.yaml file has been added. This file defines a GitHub Actions workflow named "Cross-Compile skaffold on MacOS".
  • The workflow is triggered on both push and pull_request events.
  • It uses the actions/checkout, actions/setup-go, and actions/cache actions to manage the checkout, Go setup, and caching of build artifacts.
  • The workflow compiles Skaffold for multiple platforms (linux-amd64, darwin-amd64, windows-amd64.exe, linux-arm64, darwin-arm64).
  • The make command is used to build the Skaffold binaries.

The workflow is designed to run on macos-latest runners and leverages concurrency to avoid redundant builds. The go-version is explicitly set to 1.23.3.

I'll be checking for proper error handling, build efficiency, and overall clarity of the workflow. I'll also verify that the compiled binaries are correctly generated and functional.


Here's a little haiku to lighten the mood:

MacOS now builds,
Skaffold compiles, smooth and fast,
Code flows like a stream.

Thanks,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a GitHub Actions workflow to cross-compile Skaffold on macOS. This is a good step towards ensuring compatibility across different platforms. The implementation is generally well-done, but here are a few suggestions for improvement.

@alphanota alphanota closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant