Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github action to test cross-compilation on macos #9639

Closed

Conversation

alphanota
Copy link
Contributor

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request adds a GitHub Action to test cross-compilation of Skaffold on macOS. The intent is to improve the CI/CD pipeline by ensuring that Skaffold builds correctly on macOS before release.

Here's a breakdown of the changes:

  • A new GitHub Actions workflow file, .github/workflows/compile-mac.yaml, has been added.
  • This workflow will trigger on push or pull request events.
  • It uses actions/checkout and actions/setup-go actions to set up the build environment.
  • It uses a matrix strategy to test cross-compilation for multiple platforms: linux-amd64, darwin-amd64, windows-amd64.exe, linux-arm64, and darwin-arm64.
  • The workflow caches the Go build and module cache to speed up subsequent runs.
  • Finally, it runs make ./out/VERSION and make ./out/skaffold-${{ matrix.platforms }} to build Skaffold binaries for each platform.

The workflow is designed to run on macOS runners (macos-latest).

I'll be checking for correctness, efficiency, and potential improvements to the workflow. I'll also verify that the build process works as expected for all specified platforms.


A little haiku to brighten your day:

MacOS builds now,
Cross-compiling, swift and clean,
Skaffold takes flight.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a GitHub action to test cross-compilation on macOS. The approach is good, using a matrix strategy to build for different platforms. However, there are a few points that need to be addressed.

@alphanota alphanota closed this Jan 8, 2025
@alphanota alphanota reopened this Jan 8, 2025
@alphanota alphanota closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant