Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove deprecated workflow for creating release. This would prevent accidental trigger of this workflow #9613

Closed
wants to merge 0 commits into from

Conversation

Darien-Lin
Copy link
Contributor

Description
Currently, the release is controlled in another defined workflow. Spoke with @ericzzzzzzz and he confirmed that this workflow is no longer used and should be deleted.

@Darien-Lin Darien-Lin requested a review from a team as a code owner December 13, 2024 16:32
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review up in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request removes the deprecated draft-release.yml workflow from the Skaffold repository. The workflow was previously used for creating releases but has been superseded by a different workflow. The removal prevents accidental triggering of this outdated workflow and cleans up the CI configuration. The entire .github/workflows/draft-release.yml file has been deleted.

Happy reviewing!

A tiny poem for your coding pleasure:

Old workflows fade,
New systems rise, clean and bright,
Progress lights the way.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the deprecated draft-release.yml workflow. This is a good cleanup and prevents accidental triggers. The PR description clearly explains the reason for the change and references the discussion with @ericzzzzzzz for context. Since the entire file is removed, there are no specific code suggestions within the file itself. However, I recommend updating any related documentation or READMEs to reflect this change. For example, if there's a section on releasing, it should be updated to remove any references to this workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant