Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new gcs client using cloud client libraries #9518

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Sep 4, 2024

Fixes: #9457

Description
This one removes the dependency Skaffold has with gsutil CLI implementing only the functionalities that we are using:

  • Download recursive content from a bucket, supporting wildcards: we should be behaving the same as the gsutil CLI, covering different weird cases and supporting the same syntax
  • Upload one single file to a bucket, not supporting wildcards

We now uses the Cloud client libraries for this. The affected use cases are the following:

  • Download a remote dependency from GCS
  • Save the result of a render in a bucket
  • Read rawManifests from GCS. This last one, even though the logic is there, Skaffold throws an error if we try to do it.

@renzodavid9 renzodavid9 force-pushed the gcs-client-library branch 2 times, most recently from 35d83ff to 5a1c0db Compare September 10, 2024 21:51
@renzodavid9 renzodavid9 marked this pull request as ready for review September 11, 2024 18:50
@renzodavid9 renzodavid9 merged commit da42594 into GoogleContainerTools:main Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Skaffold from gcloud CLI
2 participants