Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some initial cleanups of the config code to prepare for the larger refactoring. #142

Merged
merged 11 commits into from
Aug 6, 2021

Conversation

igorpeshansky
Copy link
Member

Extracted from #141.

@@ -296,9 +296,9 @@ func TestTail(t *testing.T) {
expectedTailConfig: `[INPUT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I would like to get rid of all these unit tests and just use the file-based tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, future PRs.

confgenerator/config.go Outdated Show resolved Hide resolved
@igorpeshansky igorpeshansky merged commit 16e9ca9 into master Aug 6, 2021
@igorpeshansky igorpeshansky deleted the igorpeshansky-config-cleanup-initial branch August 6, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants