address comments

apis/bigqueryconnection/v1alpha1/connection_types.go

@@ -38,10 +38,9 @@ type Parent struct {
 type BigQueryConnectionConnectionSpec struct {
 	Parent `json:",inline"`
 
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
 	// Immutable. Optional.
 	// The BigQuery Connection ID used for resource creation or acquisition.
-	// For creation: If specified, this value is used as the connection ID. If not provided, a UUID is generated and stored in the `status.ExternalRef` field.
+	// For creation: If specified, this value is used as the connection ID. If not provided, a UUID will be generated and assigned as the connection ID.
 	// For acquisition: This field must be provided to identify the connection resource to acquire.
 	ResourceID *string `json:"resourceID,omitempty"`
 

apis/bigqueryconnection/v1beta1/connection_reference.go

@@ -108,15 +108,16 @@ func (r *BigQueryConnectionConnectionRef) Parent() (string, error) {
 	return "", fmt.Errorf("BigQueryConnectionConnectionRef not normalized to External form or not created from `New()`")
 }
 
-func (r *BigQueryConnectionConnectionRef) ConnectionID() (string, error) {
+// ConnectionID returns the connection ID, a boolean indicating whether the connection ID is specified by user (or generated by service), and an error.
+func (r *BigQueryConnectionConnectionRef) ConnectionID() (string, bool, error) {
 	if r.External != "" {
 		_, _, id, err := parseExternal(r.External)
 		if err != nil {
-			return "", err
+			return "", false, err
 		}
-		return id, nil
+		return id, id != "", nil
 	}
-	return "", fmt.Errorf("BigQueryConnectionConnectionRef not normalized to External form or not created from `New()`")
+	return "", false, fmt.Errorf("BigQueryConnectionConnectionRef not normalized to External form or not created from `New()`")
 }
 
 // NormalizedExternal provision the "External" value.

apis/bigqueryconnection/v1beta1/connection_types.go

@@ -38,10 +38,9 @@ type Parent struct {
 type BigQueryConnectionConnectionSpec struct {
 	Parent `json:",inline"`
 
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
 	// Immutable. Optional.
 	// The BigQuery Connection ID used for resource creation or acquisition.
-	// For creation: If specified, this value is used as the connection ID. If not provided, a UUID is generated and stored in the `status.ExternalRef` field.
+	// For creation: If specified, this value is used as the connection ID. If not provided, a UUID will be generated and assigned as the connection ID.
 	// For acquisition: This field must be provided to identify the connection resource to acquire.
 	ResourceID *string `json:"resourceID,omitempty"`
 

config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_bigqueryconnectionconnections.bigqueryconnection.cnrm.cloud.google.com.yaml

@@ -308,13 +308,10 @@ spec:
                 description: 'Immutable. Optional. The BigQuery Connection ID used
                   for resource creation or acquisition. For creation: If specified,
                   this value is used as the connection ID. If not provided, a UUID
-                  is generated and stored in the `status.ExternalRef` field. For acquisition:
+                  will be generated and assigned as the connection ID. For acquisition:
                   This field must be provided to identify the connection resource
                   to acquire.'
                 type: string
-                x-kubernetes-validations:
-                - message: ResourceID field is immutable
-                  rule: self == oldSelf
               spark:
                 description: Spark properties.
                 properties:
@@ -808,13 +805,10 @@ spec:
                 description: 'Immutable. Optional. The BigQuery Connection ID used
                   for resource creation or acquisition. For creation: If specified,
                   this value is used as the connection ID. If not provided, a UUID
-                  is generated and stored in the `status.ExternalRef` field. For acquisition:
+                  will be generated and assigned as the connection ID. For acquisition:
                   This field must be provided to identify the connection resource
                   to acquire.'
                 type: string
-                x-kubernetes-validations:
-                - message: ResourceID field is immutable
-                  rule: self == oldSelf
               spark:
                 description: Spark properties.
                 properties:

pkg/controller/direct/bigqueryconnection/connection_controller.go

@@ -176,11 +176,11 @@ func (a *Adapter) Find(ctx context.Context) (bool, error) {
 
 	log.V(2).Info("getting BigQueryConnectionConnection", "name", a.id.External)
 
-	id, err := a.id.ConnectionID()
+	_, idIsSet, err := a.id.ConnectionID()
 	if err != nil {
 		return false, err
 	}
-	if id == "" { // resource is not yet created
+	if !idIsSet { // resource is not yet created
 		return false, nil
 	}
 	req := &bigqueryconnectionpb.GetConnectionRequest{Name: a.id.External}
@@ -220,11 +220,11 @@ func (a *Adapter) Create(ctx context.Context, createOp *directbase.CreateOperati
 		Parent:     parent,
 		Connection: resource,
 	}
-	id, err := a.id.ConnectionID()
+	id, isIsSet, err := a.id.ConnectionID()
 	if err != nil {
 		return err
 	}
-	if id != "" { // this means user has specified connection ID in `spec.ResourceID` field.
+	if isIsSet { // during "Create", this means user has specified connection ID in `spec.ResourceID` field.
 		req = &bigqueryconnectionpb.CreateConnectionRequest{
 			Parent:       parent,
 			ConnectionId: id,

scripts/generate-google3-docs/resource-reference/generated/resource-docs/bigqueryconnection/bigqueryconnectionconnection.md

@@ -539,7 +539,7 @@ spark:
         </td>
         <td>
             <p><code class="apitype">string</code></p>
-            <p>{% verbatim %}Immutable. Optional. The BigQuery Connection ID used for resource creation or acquisition. For creation: If specified, this value is used as the connection ID. If not provided, a UUID is generated and stored in the `status.ExternalRef` field. For acquisition: This field must be provided to identify the connection resource to acquire.{% endverbatim %}</p>
+            <p>{% verbatim %}Immutable. Optional. The BigQuery Connection ID used for resource creation or acquisition. For creation: If specified, this value is used as the connection ID. If not provided, a UUID will be generated and assigned as the connection ID. For acquisition: This field must be provided to identify the connection resource to acquire.{% endverbatim %}</p>
         </td>
     </tr>
     <tr>