Skip to content

Commit

Permalink
Merge pull request #3155 from GoogleCloudPlatform/acpana-patch-9
Browse files Browse the repository at this point in the history
docs: use new fuzzer example
  • Loading branch information
google-oss-prow[bot] authored Nov 12, 2024
2 parents f1cb53d + c793e12 commit 4ed76fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/develop-resources/deep-dives/4-add-controller.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ KCC_USE_DIRECT_RECONCILERS=<YOUR KIND> hack/compare-mock fixtures/<your_resource
### Exit Criteria

* The PRs shall pass the MockGCP tests
* For Beta resource, the roundtrip fuzz tests shall cover all the fields in `spec `and `status.observedState `fields [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/0bbac86ace6ab2f4051b574f026d5fe47fa05b75/pkg/controller/direct/redis/cluster/roundtrip_test.go#L92)
* For Beta resource, the roundtrip fuzz tests shall cover all the fields in `spec `and `status.observedState `fields. [Example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/f313b00c52f09c4a52a2eb5fe2c15fa4b30a05fd/pkg/controller/direct/discoveryengine/fuzzers.go#L26-L47)
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Follow [deep-dives Step 4](../deep-dives/4-add-controller.md).

### PR Reviews

* We require the roundtrip fuzz tests to cover all the fields in `spec` and `status.observedState` fields [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/0bbac86ace6ab2f4051b574f026d5fe47fa05b75/pkg/controller/direct/redis/cluster/roundtrip_test.go#L92) (For mapper)
* We require the roundtrip fuzz tests to cover all the fields in `spec` and `status.observedState` fields [Example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/f313b00c52f09c4a52a2eb5fe2c15fa4b30a05fd/pkg/controller/direct/discoveryengine/fuzzers.go#L26-L47)
* We require the MockGCP pass without any change to the `create.yaml`, `update.yaml` and `_generated_object_<resource>.golden.yaml` files.

## Switch to the direct controller (optional)
Expand Down

0 comments on commit 4ed76fc

Please sign in to comment.