Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gae): migrate region example to new one #5057

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 10, 2025

Description

Migrate region "examples" to "gae_flex_examples_css_go"

Fixes b/347342869

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 10, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello OremGLG and reviewers,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a summary to help everyone get up to speed:

This pull request, fix(gae): migrate region example to new one, aims to migrate the region example from "examples" to "gae_flex_examples_css_go". This addresses issue b/347342869.

The key change involves modifying the appengine_flexible/static_files/static/main.css file. Specifically:

  • Lines 15-20 (original) were updated to lines 16-22 (new).
  • The comment markers /* [START example] */ and /* [END example] */ were wrapped with new markers /* [START gae_flex_examples_css_go] */ and /* [END gae_flex_examples_css_go] */ respectively.

This appears to be a straightforward renaming of the region example within the CSS file. The checklist in the PR description indicates the author has performed necessary formatting, vetting, and testing.

I'll be checking these points as part of my full review.


A little poem to brighten your day:

A CSS file's plight,
Region names, a shifting sight,
New markers take flight.

Best regards,
Gemini/code-review-assist

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates the region example to a new one. The change is small and straightforward. The checklist is mostly irrelevant to this change and should be updated.

Comment on lines +15 to +22
/* [START gae_flex_example_css_go] */
/* [START example] */
body {
font-family: Verdana, Helvetica, sans-serif;
background-color: #CCCCFF;
}
/* [END example] */
/* [END gae_flex_example_css_go] */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The region name gae_flex_example_css_go is a bit verbose. Consider shortening it to gae_flex_css_go or similar.

Suggested change
/* [START gae_flex_example_css_go] */
/* [START example] */
body {
font-family: Verdana, Helvetica, sans-serif;
background-color: #CCCCFF;
}
/* [END example] */
/* [END gae_flex_example_css_go] */
/* [START gae_flex_css_go] */
/* [START example] */
body {
font-family: Verdana, Helvetica, sans-serif;
background-color: #CCCCFF;
}
/* [END example] */
/* [END gae_flex_css_go] */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant