-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gae): migrate region example to new one #5057
base: main
Are you sure you want to change the base?
fix(gae): migrate region example to new one #5057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello OremGLG and reviewers,
I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a summary to help everyone get up to speed:
This pull request, fix(gae): migrate region example to new one
, aims to migrate the region example from "examples" to "gae_flex_examples_css_go". This addresses issue b/347342869.
The key change involves modifying the appengine_flexible/static_files/static/main.css
file. Specifically:
- Lines 15-20 (original) were updated to lines 16-22 (new).
- The comment markers
/* [START example] */
and/* [END example] */
were wrapped with new markers/* [START gae_flex_examples_css_go] */
and/* [END gae_flex_examples_css_go] */
respectively.
This appears to be a straightforward renaming of the region example within the CSS file. The checklist in the PR description indicates the author has performed necessary formatting, vetting, and testing.
I'll be checking these points as part of my full review.
A little poem to brighten your day:
A CSS file's plight,
Region names, a shifting sight,
New markers take flight.
Best regards,
Gemini/code-review-assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request migrates the region example to a new one. The change is small and straightforward. The checklist is mostly irrelevant to this change and should be updated.
/* [START gae_flex_example_css_go] */ | ||
/* [START example] */ | ||
body { | ||
font-family: Verdana, Helvetica, sans-serif; | ||
background-color: #CCCCFF; | ||
} | ||
/* [END example] */ | ||
/* [END gae_flex_example_css_go] */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The region name gae_flex_example_css_go
is a bit verbose. Consider shortening it to gae_flex_css_go
or similar.
/* [START gae_flex_example_css_go] */ | |
/* [START example] */ | |
body { | |
font-family: Verdana, Helvetica, sans-serif; | |
background-color: #CCCCFF; | |
} | |
/* [END example] */ | |
/* [END gae_flex_example_css_go] */ | |
/* [START gae_flex_css_go] */ | |
/* [START example] */ | |
body { | |
font-family: Verdana, Helvetica, sans-serif; | |
background-color: #CCCCFF; | |
} | |
/* [END example] */ | |
/* [END gae_flex_css_go] */ |
Description
Migrate region "examples" to "gae_flex_examples_css_go"
Fixes b/347342869
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)