Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appengine): delete old region tags #5046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 9, 2025

Description

Delete old regions

Fixes
b/347825430
b/347825408

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. labels Jan 9, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by OremGLG, aims to fix issues b/347825430 and b/347825408 by deleting old region tags. The changes are focused on the endpoints/getting-started/k8s/esp_echo_http.yaml file.

Specifically, the PR removes some seemingly outdated comments related to service account secrets within the Kubernetes YAML configuration file. The before and after diffs show the removal of comment blocks denoted by # [START endpoints_secret_1], # [END endpoints_secret_1], # [START endpoints_secret_2], and # [END endpoints_secret_2]. These comments were likely placeholders or examples that are no longer needed.

Here's a breakdown of the changes:

  • File: endpoints/getting-started/k8s/esp_echo_http.yaml
    • Removed comment blocks from lines 41-47 and 65-71. These blocks were related to service account secrets.

The author has indicated that tests, code formatting, and vetting have passed. The PR is ready for review and merge once approved.


And now, a little haiku to lighten the mood:

Old tags now removed,
Clean code shines, a brighter day,
Review's swift and sure.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@OremGLG OremGLG marked this pull request as ready for review January 10, 2025 15:25
@OremGLG OremGLG requested review from a team as code owners January 10, 2025 15:25
Copy link

snippet-bot bot commented Jan 10, 2025

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@OremGLG
Copy link
Contributor Author

OremGLG commented Jan 10, 2025

@iennae I've intentionally opened this PR for review, even though Kokoro CI is failing. Kokoro CI is looking for go tests in the folder I've edited, but there are no tests to run.

@telpirion telpirion enabled auto-merge (squash) January 10, 2025 22:56
@telpirion telpirion self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants