-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appengine): delete old region tags #5046
base: main
Are you sure you want to change the base?
fix(appengine): delete old region tags #5046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:
This pull request, submitted by OremGLG, aims to fix issues b/347825430 and b/347825408 by deleting old region tags. The changes are focused on the endpoints/getting-started/k8s/esp_echo_http.yaml
file.
Specifically, the PR removes some seemingly outdated comments related to service account secrets within the Kubernetes YAML configuration file. The before and after diffs show the removal of comment blocks denoted by # [START endpoints_secret_1]
, # [END endpoints_secret_1]
, # [START endpoints_secret_2]
, and # [END endpoints_secret_2]
. These comments were likely placeholders or examples that are no longer needed.
Here's a breakdown of the changes:
- File:
endpoints/getting-started/k8s/esp_echo_http.yaml
- Removed comment blocks from lines 41-47 and 65-71. These blocks were related to service account secrets.
The author has indicated that tests, code formatting, and vetting have passed. The PR is ready for review and merge once approved.
And now, a little haiku to lighten the mood:
Old tags now removed,
Clean code shines, a brighter day,
Review's swift and sure.
Gemini encountered an error creating the review. You can try again by commenting |
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
@iennae I've intentionally opened this PR for review, even though Kokoro CI is failing. Kokoro CI is looking for go tests in the folder I've edited, but there are no tests to run. |
Description
Delete old regions
Fixes
b/347825430
b/347825408
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)