Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endpoints): delete old region tags #5038

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 9, 2025

Description

Add _go suffix to regions

Fixes
b/347825430
b/347825408

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary of the changes for you and other reviewers to quickly get up to speed:

This pull request, submitted by OremGLG, aims to fix outdated region tags in the endpoints directory of the golang-samples repository. The intent is to clean up and improve the codebase by removing obsolete region tags. This is likely in response to bug reports b/347825430 and b/347825408.

Here's a breakdown of the changes:

  • docs/appengine/storage/app.go: This file has been updated to add and remove gae_storage_ prefixes to various code sections, improving organization and clarity. The changes are spread across multiple sections of the file, specifically around lines 15-18, 33-37, 67-81, 126-136, 154-167, 181-196, 200-216, and 239-276. The changes primarily involve adding and removing comment blocks related to Google Cloud Storage API usage.
  • endpoints/getting-started/k8s/esp_echo_http.yaml: This file has been modified to remove redundant comment blocks related to Kubernetes service account credentials and endpoint services. The changes are concentrated around lines 39-48 and 55-74. These changes streamline the Kubernetes deployment configuration file.

The author has indicated that all tests, formatting, and vetting checks passed. There are a few remaining checklist items related to API enabling, environment variables, and CODEOWNERS updates that need attention.

I'll provide a more detailed review shortly.


And now for a little haiku to brighten your day:

Tags cleaned, code refined,
Bugs banished, peace restored now,
Code review's sweet joy.

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Jan 9, 2025
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@OremGLG OremGLG marked this pull request as ready for review January 9, 2025 22:53
@OremGLG OremGLG requested review from a team as code owners January 9, 2025 22:53
@OremGLG OremGLG closed this Jan 9, 2025
@OremGLG OremGLG deleted the garciadiaz-migrate-region-347825430-step2 branch January 9, 2025 22:54
Copy link

snippet-bot bot commented Jan 9, 2025

Here is the summary of changes.

You are about to add 6 region tags.
You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant