Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(many): rename Golang to Go #5036

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

jba
Copy link
Contributor

@jba jba commented Jan 9, 2025

Description

The language's proper name is "Go", not "Golang".

Checklist

  • [x ] I have followed Contributing Guidelines from CONTRIBUTING.MD
  • [x ] Tests pass: go test -v ./.. (see Testing)
  • [x ] Code formatted: gofmt (see Formatting)
  • [ x] Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x ] Please merge this PR for me once it is approved

The language's proper name is "Go", not "Golang".
@jba jba requested review from a team as code owners January 9, 2025 16:32
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 9, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, here's a summary of the changes for you and other reviewers to quickly get up to speed:

This pull request, authored by jba, aims to rename all instances of "Golang" to "Go" within the golang-samples repository. The rationale is that "Go" is the language's official and proper name.

Here's a breakdown of the changes:

  • Intent: Correctly use the language's official name, "Go", instead of the informal "Golang".
  • Changes: The PR makes numerous updates across various sample applications and supporting files. The changes are primarily textual replacements of "Golang" with "Go". Specific examples include:
    • Updates to Dockerfile comments in several directories (e.g., appengine, cloudsql, run, etc.).
    • Modification of HTML titles in index.html files (e.g., in appengine_flexible/websockets/static/index.html).
    • Correction of a string in bigtable/helloworld/main.go.
    • Updates to Kokoro configuration scripts (testing/kokoro/configure_cloudsql.bash).
  • Activity: The PR author has indicated that all tests, formatting, and vetting checks have passed.

The following table summarizes the affected files:

File Change Summary
appengine/go11x/tasks/handle_task/Dockerfile Updated comment to use "Go" instead of "Golang".
appengine_flexible/go115_and_earlier/websockets/static/index.html Updated HTML title to use "Go" instead of "Golang".
appengine_flexible/websockets/static/index.html Updated HTML title to use "Go" instead of "Golang".
bigtable/helloworld/main.go Updated a greeting string to use "Go" instead of "golang".
cloudsql/mysql/database-sql/Dockerfile, cloudsql/postgres/database-sql/Dockerfile, cloudsql/sqlserver/database-sql/Dockerfile, eventarc/audit_storage/Dockerfile, eventarc/generic/Dockerfile, eventarc/pubsub/Dockerfile, getting-started/gopher-run/Dockerfile, memorystore/redis/cloud_run_deployment/Dockerfile, run/grpc-ping/Dockerfile, run/grpc-server-streaming/Dockerfile, run/hello-broken/Dockerfile, run/helloworld/Dockerfile, run/image-processing/Dockerfile, run/logging-manual/Dockerfile, run/markdown-preview/editor/Dockerfile, run/markdown-preview/renderer/Dockerfile, run/pubsub/Dockerfile, run/sigterm-handler/Dockerfile, run/system_package/Dockerfile Updated comments in Dockerfiles to use "Go" instead of "Golang".
opentelemetry/instrumentation/app/logger.go Updated comment to remove reference to "golang" context.
testing/kokoro/configure_cloudsql.bash Updated comment to use "Go" instead of "Golang".

Short and sweet, a coding haiku:

Go's name, clear and bright,
Golang's shadow fades to grey,
Clean code takes flight.

Let me know if you have any questions.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request renames "Golang" to "Go" across the repository, which is a good change as "Go" is the language's official name. The changes seem comprehensive and the PR description and checklist are well-maintained.

@@ -36,7 +36,7 @@ type spanContextLogHandler struct {
// Handle overrides slog.Handler's Handle method. This adds attributes from the
// span context to the slog.Record.
func (t *spanContextLogHandler) Handle(ctx context.Context, record slog.Record) error {
// Get the SpanContext from the golang Context.
// Get the SpanContext from the context.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

It's more concise and accurate to simply refer to "the context" rather than "the golang context". The type is already clear.

Suggested change
// Get the SpanContext from the context.
// Get the SpanContext from the context.

Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it ... would you please also put "Go" in initial caps when it shows up in comments? I started switching some of the files, but there's a bunch.

Thanks!

@telpirion telpirion self-assigned this Jan 10, 2025
@telpirion telpirion enabled auto-merge (squash) January 10, 2025 22:57
@telpirion telpirion disabled auto-merge January 13, 2025 21:29
@telpirion telpirion merged commit a24ed16 into GoogleCloudPlatform:main Jan 13, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants