Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language): delete old region tag "imports" #5035

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 8, 2025

Description

Delete old region tag "imports"

Fixes b/347826215

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the api: language Issues related to the Cloud Natural Language API API. label Jan 8, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello everyone!

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by OremGLG, aims to fix issue b/347826215 by removing an outdated region tag from the analyze.go file within the language directory. Specifically, the changes involve deleting the now-redundant // [START imports] and // [END imports] tags from lines 29-32 of language/analyze/analyze.go.

Here's a breakdown of the changes:

  • File Changed: language/analyze/analyze.go
  • Lines Affected: 29-32
  • Change Summary: Removed duplicate import region tags (// [START imports] and // [END imports]). The // [START language_imports] and // [END language_imports] tags remain.

The author has indicated that all tests, formatting, and vetting checks have passed. They've also completed the checklist provided in the PR description.


And now, a little haiku to lighten the mood:

Old tags now removed,
Clean code, a joyful sight,
Reviewing's a breeze.

Looking forward to completing the review!

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 8, 2025
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@OremGLG OremGLG marked this pull request as ready for review January 8, 2025 22:46
@OremGLG OremGLG requested review from a team as code owners January 8, 2025 22:46
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by OremGLG, aims to delete the outdated region tag "imports" from the language/analyze/analyze.go file. The intent is to clean up the code and remove redundant or obsolete comments.

Here's a breakdown of the changes:

  • File Changed: language/analyze/analyze.go
  • Change Summary: Lines 29-31 were removed. These lines contained the now-obsolete // [START imports] and // [END imports] comments. The language and languagepb imports remain, as expected.

Before:

26:	"github.com/golang/protobuf/proto"
27:
28:	// [START language_imports]
29:	// [START imports]
30:	language "cloud.google.com/go/language/apiv1"
31:	"cloud.google.com/go/language/apiv1/languagepb"
32:	// [END imports]
33:	// [END language_imports]
34:)
35:

After:

26:	"github.com/golang/protobuf/proto"
27:
28:	// [START language_imports]
29:	language "cloud.google.com/go/language/apiv1"
30:	"cloud.google.com/go/language/apiv1/languagepb"
31:	// [END language_imports]
32:)
33:

The pull request also references a Google internal bug (b/347826215), suggesting this is a cleanup task related to that bug fix.


A little haiku to brighten your day:

Old tags now removed,
Code cleaner, bright and new,
Review swiftly done.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a summary to help everyone get up to speed:

This pull request, submitted by OremGLG, aims to fix issue b/347826215 by removing an outdated region tag. Specifically:

  • Intent: Delete the obsolete imports region tag from the language/analyze/analyze.go file.
  • Changes: The pull request modifies language/analyze/analyze.go to remove lines 29-32, which contained the now-unnecessary // [START imports] and // [END imports] tags. This cleans up the code and removes redundancy.

The changes are straightforward and well-documented. The author has already completed the formatting and vetting steps, and the checklist indicates the PR is ready for merging once approved.

Here's a table summarizing the changes:

File Change
language/analyze/analyze.go Removed outdated region tag imports (lines 29-32).

I'll be completing a thorough review shortly, but this summary should provide a quick overview of the changes. Let me know if you have any questions.

And now, a little haiku to lighten the mood:

Old tags now removed,
Code cleaner, bright and new,
Review flows smoothly.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Copy link

snippet-bot bot commented Jan 8, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae iennae merged commit 8a256db into GoogleCloudPlatform:main Jan 9, 2025
9 checks passed
@OremGLG OremGLG deleted the garciadiaz-migrate-region-step-2-347826215 branch January 9, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants