Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): fix typo in logging.go #4886

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

eripe970
Copy link
Contributor

@eripe970 eripe970 commented Dec 18, 2024

Fix spelling

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@eripe970 eripe970 requested review from a team as code owners December 18, 2024 21:43
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eripe970 and reviewers,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request focuses on improving the grammar in the logger.go file within the opentelemetry/instrumentation/app directory. The primary change is a minor grammatical correction in a comment:

  • File Changed: opentelemetry/instrumentation/app/logger.go
  • Change Summary: The word "an" was changed to "a" in the comment describing the spanContextLogHandler struct. This corrects a grammatical error.
  • Intent: To improve the overall readability and correctness of the code comments.

The change is small but contributes to cleaner, more professional code. I'll provide a more detailed review shortly.

A tiny poem for your coding pleasure:

A simple fix made,
Grammar now flows smoothly on,
Code shines anew.

Thanks!

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 18, 2024
@eripe970 eripe970 closed this Dec 18, 2024
@eripe970 eripe970 reopened this Dec 18, 2024
@eripe970 eripe970 changed the title Grammar - Update logger.go chore(logging): fix typo in logging.go Dec 18, 2024
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your diligence in supporting samples :) fixing typos is helpful!

@iennae iennae merged commit db55cc2 into GoogleCloudPlatform:main Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants