Add tracing hello world #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
igorbernstein2
approved these changes
Dec 6, 2017
java/tracing-hello-world/README.md
Outdated
|
|
||
| ## Before you begin | ||
|
|
||
| This sample assumes you have [Java 8][java8] installed. |
There was a problem hiding this comment.
might be good to emphasis that a jre is not enough and a jdk is required
|
|
||
| Generate a credentials file by running the [application-default login](https://cloud.google.com/sdk/gcloud/reference/auth/application-default/login) command: | ||
|
|
||
| gcloud auth application-default login |
There was a problem hiding this comment.
I think we should discourage people from using application default creds and encourage them to use service accounts
There was a problem hiding this comment.
I created issue #271 to switch all examples to service accounts. For now, can we keep application-default credentials so that we can keep this issue consistent with the others?
java/tracing-hello-world/pom.xml
Outdated
| @@ -0,0 +1,116 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| ~ Copyright (c) 2016 Google Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
please update the year
| import java.io.IOException; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import javax.swing.plaf.synth.SynthSeparatorUI; |
There was a problem hiding this comment.
please clean up imports
|
The comments were addressed. PTAL. |
igorbernstein2
approved these changes
Dec 6, 2017
sduskis
added a commit
to sduskis/cloud-bigtable-examples
that referenced
this pull request
Dec 13, 2017
* Adding a Hello World Java with tracing. * Updating HelloWorld docs and readm * Addressing comments
sduskis
added a commit
that referenced
this pull request
Feb 22, 2018
* Add tracing hello world (#270) * Adding a Hello World Java with tracing. * Updating HelloWorld docs and readm * Addressing comments * Some fixes to the readme * Adding new lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a hello world with tracing example.
You can see the readme here: https://github.com/sduskis/cloud-bigtable-examples/tree/add_tracing_hello_world/java/tracing-hello-world