-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIPELINE-2054: Improve testing | Part II: utils #185
Open
tomaslink
wants to merge
12
commits into
PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests
Choose a base branch
from
PIPELINE-2054-segment-improve-testing-part-2-utils
base: PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PIPELINE-2054: Improve testing | Part II: utils #185
tomaslink
wants to merge
12
commits into
PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests
from
PIPELINE-2054-segment-improve-testing-part-2-utils
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests #185 +/- ##
===================================================================================================
+ Coverage 79.90% 85.49% +5.58%
===================================================================================================
Files 29 28 -1
Lines 1110 1096 -14
Branches 159 118 -41
===================================================================================================
+ Hits 887 937 +50
+ Misses 207 146 -61
+ Partials 16 13 -3 ☔ View full report in Codecov by Sentry. |
7b64e3a
to
0381eb9
Compare
58ff9de
to
529e867
Compare
0381eb9
to
77f18da
Compare
1db1e2e
to
6d3ed2b
Compare
77f18da
to
6132cfc
Compare
6132cfc
to
a9c4598
Compare
86c7576
to
c60c221
Compare
c60c221
to
17017ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://globalfishingwatch.atlassian.net/browse/PIPELINE-2054
https://globalfishingwatch.atlassian.net/browse/PIPELINE-2053