Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPELINE-2054: Improve testing | Part II: utils #185

Open
wants to merge 12 commits into
base: PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests
Choose a base branch
from

Conversation

tomaslink
Copy link
Contributor

@tomaslink tomaslink commented Jun 19, 2024

@tomaslink tomaslink self-assigned this Jun 19, 2024
@tomaslink tomaslink changed the base branch from develop to PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests June 19, 2024 21:26
@tomaslink tomaslink changed the title PIPELINE-2054: Improve testing | Part I: utils PIPELINE-2054: Improve testing | Part II: utils Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 89.92248% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (6d3ed2b) to head (17017ea).

Files Patch % Lines
pipe_segment/pipeline.py 50.00% 8 Missing ⚠️
pipe_segment/segment_identity/pipeline.py 33.33% 4 Missing ⚠️
pipe_segment/utils/bq_tools.py 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests     #185      +/-   ##
===================================================================================================
+ Coverage                                                            79.90%   85.49%   +5.58%     
===================================================================================================
  Files                                                                   29       28       -1     
  Lines                                                                 1110     1096      -14     
  Branches                                                               159      118      -41     
===================================================================================================
+ Hits                                                                   887      937      +50     
+ Misses                                                                 207      146      -61     
+ Partials                                                                16       13       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch 10 times, most recently from 7b64e3a to 0381eb9 Compare June 26, 2024 14:03
@tomaslink tomaslink force-pushed the PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests branch from 58ff9de to 529e867 Compare June 26, 2024 20:20
@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch from 0381eb9 to 77f18da Compare June 26, 2024 20:22
@tomaslink tomaslink force-pushed the PIPELINE-2001-pipe-segment-increase-code-coverage-in-unit-tests branch 2 times, most recently from 1db1e2e to 6d3ed2b Compare June 26, 2024 21:19
@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch from 77f18da to 6132cfc Compare June 27, 2024 04:01
@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch from 6132cfc to a9c4598 Compare June 27, 2024 17:06
@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch 2 times, most recently from 86c7576 to c60c221 Compare June 28, 2024 00:24
@tomaslink tomaslink force-pushed the PIPELINE-2054-segment-improve-testing-part-2-utils branch from c60c221 to 17017ea Compare June 28, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant