-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support New Segmenter #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r segments as well
…d; stringify both segment and messages ssvid so that cogroup works right; fix tests
…as used for sharding segments
enriquetuya
requested changes
Nov 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitsofbits check my questions and comments below.
Also, we need to add an entry to the CHANGES.log stating the changes.
…the legacy table for identity segment tables.
enriquetuya
changed the base branch from
gfw-tasks-1143-new-segmenter
to
develop
March 11, 2020 20:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Support
so that they are available on segments imported from previous day.
pipeline and one that is for the new stitcher and dump to different output files.
Software updates.
pipe-tools
3.0: this fixed a bunch of versioning problems andneeded to be done eventually.
pipeline will run under Python 3 yet.
Reduce Memory Usage
See Issue #100
Improves memory usage / performance in three ways:
noise segments so this results in a large improvement in memory footprint.'
This means each worker machine only gets the segments related to the messages it is
processing further reducing memory footprint and slightly speeding operations.
segments, and may reduce per worker memory usage.
Net effect is that I can run over 1 month with 8192 MiB per worker, and perhaps less (that's the minimum I've tried), when previously I was still getting crashes with 64,000 MiB per worker!