Generate sitemap for all sections and spaces #2767
Merged
+205
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c333d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gregberge
force-pushed
the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
from
cfb0c65 to
403f21b
Compare
gregberge
commented
Jan 22, 2025
packages/gitbook/src/app/middleware/(site)/(core)/~gitbook/sitemaps/[[...pathname]]/route.ts
Outdated
Show resolved
Hide resolved
gregberge
commented
Jan 22, 2025
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
force-pushed
the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
from
403f21b to
d553914
Compare
gregberge
force-pushed
the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
from
d553914 to
f80665c
Compare
SamyPesse
approved these changes
Jan 22, 2025
packages/gitbook/src/app/middleware/(site)/(core)/sitemap-pages.xml/route.ts
Outdated
Show resolved
Hide resolved
packages/gitbook/src/app/middleware/(site)/(core)/sitemap.xml/route.ts
Outdated
Show resolved
Hide resolved
packages/gitbook/src/app/middleware/(site)/(core)/sitemap.xml/route.ts
Outdated
Show resolved
Hide resolved
gregberge
force-pushed
the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
2 times, most recently
from
bf92a33 to
c574d0f
Compare
Also refactor a bunch of the code to prepare other usages.
gregberge
force-pushed
the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
from
c574d0f to
2c333d4
Compare
gregberge
deleted the
greg/rnd-5955-improve-sitemapxml-generation-for-variantssections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the sitemap does not include all site links. With this new approach we include all the links in the site by having a root site map and one site map per section and site space.
I also simplified the site space markup:
Example