Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply vertical alignment to Tables as configured in-app #2627

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

viktorrenkema
Copy link
Contributor

@viktorrenkema viktorrenkema commented Dec 12, 2024

This PR implements the published-content side of the ability to set a vertical alignment on a Table and/or Column in the GitBook app editor.

Is blocked by the other PR on the app-side: https://github.com/GitbookIO/gitbook-x/pull/16146

Copy link

linear bot commented Dec 12, 2024

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 71267a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch 2 times, most recently from 8df1ebb to 2681b52 Compare December 17, 2024 07:57
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch from 2681b52 to 3fdadcb Compare January 10, 2025 09:07
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch from 3fdadcb to ce5d880 Compare January 12, 2025 08:14
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch 4 times, most recently from 932e865 to 8bb1321 Compare January 13, 2025 13:18
Copy link
Contributor

github-actions bot commented Jan 13, 2025

GitBook Preview
Latest commit: https://80b33333.gitbook-open.pages.dev
PR: https://pr2627.gitbook-open.pages.dev

Copy link

argos-ci bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 55 changed Jan 14, 2025, 8:43 AM

@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch 3 times, most recently from 0a91b86 to 263a8bf Compare January 13, 2025 13:48
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5795/vertical-align-in-tables branch from 263a8bf to 71267a1 Compare January 14, 2025 08:14
@viktorrenkema viktorrenkema merged commit 960e25a into main Jan 14, 2025
9 checks passed
@viktorrenkema viktorrenkema deleted the viktor/rnd-5795/vertical-align-in-tables branch January 14, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants