Allow only valid values for theme query string

Fix GITBOOK-OPEN-1X8D
GitbookIO · Jan 14, 2025 · fa65c78 · fa65c78
1 parent 26e6401
commit fa65c78
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/loud-files-tap.md b/.changeset/loud-files-tap.md
@@ -0,0 +1,5 @@
+---
+'gitbook': patch
+---
+
+Allow only good values for theme query parameter. Avoid having a 500 error when we pass an invalid value.
diff --git a/packages/gitbook/src/middleware.ts b/packages/gitbook/src/middleware.ts
@@ -264,7 +264,7 @@ export async function middleware(request: NextRequest) {
     }
 
     const theme = url.searchParams.get('theme');
-    if (theme) {
+    if (theme === 'dark' || theme === 'light') {
         headers.set('x-gitbook-theme', theme);
     }